105346 - eyesonff.com - [MARGIN-C] display problem with title bar's

Status: RESOLVED FIXED

(Core :: Layout, defect, P4)

Description

[Thomas Buffington Jr.]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win95; en-US; rv:0.9.5) Gecko/20011011
BuildID:    2001101117

Top title bar http://www.eyesonff.com/images/main.jpg which is located on the
main page of http://www.eyesonff.com/ should be raised all the way to the top
and not be lowered as is.

Error: unterminated string literal
Source File: http://www.eyesonff.com/
Line: 63, Column: 131
Source Code:
var cDoc=document;if(cDoc.domain.indexOf(siteDomain)==-1) siteDomain='';if
(siteDomain.length>0) siteDomain="'domain=."+siteDomain+"

Website has tons of Unterminated string lateral's. I have tested the problem in
other browsers and have had no problem with the exception of the Mozilla which
in even Netscape display's the title bar wrong.

Reproducible: Couldn't Reproduce

Comment 1

[R.K.Aa.]

dup of bug 105278?

Comment 2

[Marc Attinasi]

Attachment: testcase - the image is in some nested block

Comment 3

[Marc Attinasi]

Attachment: Testcase without borders (the borders in the previous attachment cause margin-collapsing not to happen)

Comment 4

[Marc Attinasi]

Comment on attachment 54093 [details]
testcase - the image is in some nested block

testcase still had borders on teh blocks - invalid. Updated with another testcase.

Comment 5

[Marc Attinasi]

Collapsing margin issue - probably a dup - I'll look.

Comment 6

[Marc Attinasi]

looks like bug 18206

Comment 7

[Mats Palmgren (inactive)]

Attachment: Simplified testcase

Comment 8

[Mats Palmgren (inactive)]

Seems more like a Parser issue to me.

Comment 9

[Marc Attinasi]

The markup:

div
 p
  div
   img

gets parsed into 

div
 p /p
 div img /div
 p /p
/div

this looks correct (except for the p /p after the div img /div, but that should
not impact the offset from the top for the img).

I think the problem is that the first p is not getting collapsed. Add this style
rule and see what I mean:

<style>
 body > div >:empty:first-node { margin: 0; }
</style>

That will tell the empty P in the div to collapse its margins.

Mats, why are you thinking this is a parser problem?

Comment 10

[Danny Wilber]

Any status on this issue? Problem appears with Windows ME. Any help would be
appreciated as I realize there are more important bugs being worked on but I
would like to see a resolution or at least some new information. Thanks.

Comment 11

[Thomas Buffington Jr.]

Confirmation of what has been stated by Mr. Wilber is true with all Windows OS' 
can be clearly seen. Kind of strange how this only happens with Mozilla 
formatted browsers, could it be the <IFRAME> isn't parsing at the top or is it 
a problem with the style seets?

Comment 12

[Thomas Buffington Jr.]

URL of where this layout error occurs has changed it is now at
http://www.eyesonff.com/index2.shtml there are also two unterminated string
constants. One being on the main page the other being located on the
Index2.shtml section.

Comment 13

[rubydoo123]

Not sure if this will help any, but when I dump the content tree, this is what I 
get from the:

------- Additional Comment #7 From Mats Palmgren 2001-10-20 15:25 -------

Created an attachment (id=54366)
Simplified testcase

running that testcase, this is what I get:

|    DIV
|    |    P
|    |    DIV
|    |    |    IMG
|    |    P
|    A
|    #text

That first P is clearly not collapsing

Comment 14

[rubydoo123]

forgot to mention I was using the build from 2001121003 on win98

Comment 15

[Danny Wilber]

These were found while using the JAVA script console

Error: unterminated string literal
Source File: http://www.eyesonff.com/index2.shtml
Line: 59, Column: 131
Source Code:
var cDoc=document;if(cDoc.domain.indexOf(siteDomain)==-1) siteDomain='';if
(siteDomain.length>0) siteDomain="'domain=."+siteDomain+"

Error: unterminated string literal
Source File: http://www.eyesonff.com/
Line: 32, Column: 131
Source Code:
var cDoc=document;if(cDoc.domain.indexOf(siteDomain)==-1) siteDomain='';if
(siteDomain.length>0) siteDomain="'domain=."+siteDomain+"

Comment 16

[Thomas Buffington Jr.]

Attachment: Proper display of eyes on FF

I am using this attachment as well as another to show comparison to help the
webmaster situate the problem and hopefully fix it a.s.a.p.

Comment 17

[Thomas Buffington Jr.]

Attachment: How Mozilla/Netscape displays Eyes on FF

Comment 18

[Thomas Buffington Jr.]

Shortning the summary and also including that this problem is occuring with the 
other sections of the site with Mozilla build 2002050504. I have posted this in 
the forums on the site and hope the problem can be fixed a.s.a.p.

Comment 19

[Mats Palmgren (inactive)]

Attachment: Testcase #4

Marc, sorry for the late reply: Yes, you are right it's not a parser issue,
it's
a margin collapsing problem of an empty element. Results with Testcase #4:

Mozilla - 4 areas: white, red,	  yellow, white.
IE6	- 3 areas: white, yellow, red.
Opera6	- 3 areas: white, yellow, white.

There should only be three areas. I don't know what color the first and last
should be - it depends on which margin you pick when you have two of equal
size.
IE seems to pick the "top-most", Mozilla and Opera the "outer-most".
http://www.w3.org/TR/REC-CSS2/box.html doesn't say what to do.

Note that we collapse the bottom P correctly, it seems we handle
top-bottom-bottom but not top-top-bottom.

Comment 20

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix to bug 44242 checked in to trunk, 2002-11-28 11:29 PST.