105526 - Land Initial S/MIME on the trunk.

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect, P1)

Description

[Stephane Saux]

Tracking bug for
http://komodo.mozilla.org/planning/branches.cgi Initial S/MIME landing carpool.

Comment 1

[Stephane Saux]

Attachment: Initial plan.

Comment 2

[Stephane Saux]

cc ddrinan, kaie

Comment 3

[Stephane Saux]

The initial S/MIME landing will provide the Mozilla product with the first
integration of PSM and Mail/News with the NSS S/MIME toolkit (see
http://mozilla.org/projects/security/pki/nss/#smime)

It will provide very minimal UI functionality:

  - When reading signed and/or encrypted email the browser will pop up a
javascript alert telling the user about the s/mime status of the message.
  - On the compose window, the options menu will have a security item allowing
the user to encrypt and/or sign the message.

Comment 4

[(not reading, please use [e-mail] instead)]

> - When reading signed and/or encrypted email the browser will pop up a
> javascript alert telling the user about the s/mime status of the message.

poping up an alert on seems pretty intrusive, I'm sure that's just a temporary
thing.

do signed / encryped emails have any special headers, or is the mime type
something specific, like "application/pkcs7-mime"

see mscott's messageHeaderSink in msgHdrViewOverlay.js

if you can tell the message is signed / encrypted from the headers, you can use
that to poke the header area of the message pane.

cc' mscott for comment.  cc jglick for UI issues.  

Comment 5

[David P. Drinan]

Attachment: Patch for PSM changes.

Comment 6

[David P. Drinan]

Adding javi to cc-list.

Javi,

Please review this patch.

Thannks.

Comment 7

[Kai Engert [:KaiE:]]

Attachment: Updated patch

Comment 8

[Kai Engert [:KaiE:]]

Javi, can you please review the updated patch?

Comment 9

[Christopher Blizzard (:blizzard)]

+  <key id="esc-key"    keycode="VK_ESCAPE" oncommand="window.close();"/>

Shouldn't that be doCancel();?

+printf("Cert Nickname: %s\n", nickname.get());

That shouldn't be there.

Other than that the code looks fine to me.  sr=blizzard

Comment 10

[Stephane Saux]

Attachment: Performance and size evaluation between experimental build and trunk builds

Comment 11

[Kai Engert [:KaiE:]]

blizzard: You are right with "doCancel" and the printf statement, we will change
this prior to checkin to the trunk.

I already checked this change in on OTIS_TEST_BRANCH.

Comment 12

[Kai Engert [:KaiE:]]

Comment on attachment 55264 [details] [diff] [review]
Updated patch

sr=blizzard

Comment 13

[Kai Engert [:KaiE:]]

*** Bug 106102 has been marked as a duplicate of this bug. ***

Comment 14

[Kai Engert [:KaiE:]]

The landing of S/Mime will include the other's tab for cert manager as requested
in bug 106102.

Comment 15

[Javier Delgadillo]

Comment on attachment 55264 [details] [diff] [review]
Updated patch

r=javi on updated patch

Comment 16

[David P. Drinan]

Checked into the trunk. Marking FIXED.

Comment 17

[John Unruh]

Veerified.

Comment 18

[James Rome]

It did not work for me on the Linux 11/11 release. Even though there were
options to sign and encrypt the message in the compose window, nothing happened.
It also never popped up a box to ask me for my certificate.

I also feel strongly that the security manager should be on the tools/security
menu rather than in the totally unobvious preferences/advanced/security menu. I
was unable to find it there. Security is a dynamic thing that needs to be done
in real time, and is not a static preference.