105761 - When using cut/copy and paste on text that is part of a link, the pasted text loses the link

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P1)

Description

[TucsonTester1]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:0.9.4)
Gecko/20011017 Netscape6/6.2
BuildID:    20011017

If you use cut or copy on text that is part of a link, and then paste that text
into composer, the text you have pasted will no longer be a link.  This only
happens if the text you are copying is only a portion of the linked text.  If
you copy all text that is part of the original link, then the pasted text will
still be linked.

Reproducible: Always
Steps to Reproduce:
1.Open a blank page in composer
2.Click on Link
3.For Link Text, type in Netscape Website
4.For Link Location, type in http://www.netscape.com and click ok
5.Click on Format and select Discontinue link
6.Hit the enter key
7.With mouse, highlight the word Website
8.Hold down control key and click c to copy
9.Click on the second line so the cursor is there
10.Hold down control and click v to paste


Actual Results:  The pasted text is normal text, it is not linked to
www.netscape.com.  I tried this in Netscape 4.7, and it is working as expected.

Expected Results:  I would expect the pasted text to still be linked to netscape.com

If you highlight the entire linked text (Netscape Website) and then paste it,
the pasted text will still be a link.  But you must copy the entire linked text
and paste it for the pasted text to still be a link. 

One note on reproducing this.  Step 5 is not necessary to reproduce the actual
bug, but depending on how you edit the page, a link can continue to the next
line without you telling it to.  In which case pasting text to that line would
automatically become part of the link.  Which might make it look like the bug
was not happening.

Comment 1

[Tuukka Tolvanen (sp3000)]

win98 2001101803 trunk
Unable to reproduce exactly as specified... If I make a link "Netscape Website"
and select "Website" and paste, the pasted text will be a link. However, if I
select "Websit", "etscape Websit", or the like, the pasted text won't be a link;
the first or last character has to be included. Also, at step 5., the
"discontinue Link" menu item was not available. Close enough still, marking NEW.

(reporter, perhaps your link text ended up as "Netscape Website ", i.e. with a
space at the end, as the last character?)

Comment 2

[Syd Logan]

Charles, what do you think -- is the 4.7 behaviour correct, or us?

Comment 3

[Charles Manske]

If it works in 4.7, it's because we made a special case of this situation.
Normally, one would not expect a partial selection to include inline attributes,
isn't that right, Joe?
Brade, JFrancis: Do we want this behavior?

Comment 4

[Kathleen :Brade]

-->jfrancis

Comment 5

[Joe Francis]

attaching patch

Comment 6

[Joe Francis]

Attachment: patch to content/base/src/nsDocumentEncoder.cpp

Comment 7

[Kathleen :Brade]

marking EDITORBASE+ per meeting

Comment 8

[kinmoz]

Comment on attachment 65163 [details] [diff] [review]
patch to content/base/src/nsDocumentEncoder.cpp

sr=[e-mail]

Comment 9

[Joe Francis]

099 to 1.0; set pri to 1 for these pushed off EB+ bugs

Comment 10

[Joe Francis]

The days of having a half dozen milestones out in front of us to divide bugs 
between seem to be gone, though I dont know why.  Lumping everything together as 
far out as I can.  I'll pull back things that I am working on as I go.

Comment 11

[Charles Manske]

Comment on attachment 65163 [details] [diff] [review]
patch to content/base/src/nsDocumentEncoder.cpp

r=cmanske
Looks like a good idea to me!

Comment 12

[Charles Manske]

Joe: this looks fine - Check it in!

Comment 13

[Joe Francis]

fix landed on trunk

Comment 14

[rubydoo123]

using trunk build from 2003040308, works fine. Entered some text, selected a
word and made it a link. Selected part of the link text, copied and pasted to
the end of the line, the pasted text and link came over just fine.