105804 - Transparent animated GIF displays incorrectly

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Ian Tresman]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9.5) Gecko/20011011
BuildID:    2001101117

An animated GIF which is supposed to display in red (and does so in Netscape
4.77) is completely transparently where the red is supposed to be.

Reproducible: Always
Steps to Reproduce:
1. Point Browser to http://www.michael-noakes.co.uk/
2. Watch image below "View here"


Actual Results:  Animation starts, but where it should be red, it is transparent

Expected Results:  Animation should've been in red.

Comment 1

[Boris Zbarsky [:bzbarsky]]

imagelib.  For reference, with trunk build 2001-10-18-08 on linux I cannot see
the animated gif at all!

Comment 2

[alge]

worksforme (: 2001101808 redhat 7.0+

Comment 3

[Terri Preston]

I still see this behavior on Win XP build 2001110209

Comment 4

[Vincent Nicolas]

Is there any news about this ? It is one of the bug that makes advocacy of
Mozilla harder.

Comment 5

[gavin long]

Still there, win98SE, 2002010403.  The .gif looks fine in Irfanview and IE5.5

Comment 6

[Morten Nilsen]

WFM linux, cvs tip...
setting pp keyword

Comment 7

[basic]

Attachment: testcase (image in question with different background colors)

build 2002020603 win32 trunk

still seeing the bug. Could this be a dup?

Comment 8

[Nivedita (gone)]

taking this bug from pavlov

Comment 9

[Nivedita (gone)]

Attachment: patch file for fixing the transparent animated gif

The disposal method of animated the gif was DISPOSE_NOT_SPECIFIED, and here the
BuildCompositeMask was not being called which correctly handles the masking of
overlay frame and its background. Since DISPOSE_KEEP was already doing this.
Hence clubbed the cases of DISPOSE_NOT_SPECIFIED and DISPOSE_KEEP

Comment 10

[basic]

is the patch ready for review?

Comment 11

[Nivedita (gone)]

yes, it is ready for review.

Comment 12

[Stuart Parmenter]

Comment on attachment 70257 [details] [diff] [review]
patch file for fixing the transparent animated gif

r=pavlov

Comment 13

[tor]

WFM without the patch - red signature, transparent background.

Comment 14

[Nivedita (gone)]

Can you please verify the given test case, where in differnt back ground colors 
are used. On the white back ground, the red signature is clear, but when against 
the other background color, the signature appears in red+background color. That 
is reason why BuildCompositeMask is needed.

Comment 15

[Nivedita (gone)]

The test case id=68348 happens on Windows platform.

Comment 16

[tor]

Without patch transparency appears correct on all backgrounds in the testcase.

Comment 17

[Nivedita (gone)]

This test case is valid for Windows platform.

Comment 18

[[not reading bugmail]]

tor, it doesn't work in windows.. just open IE and take a look at the
difference, there is no animation and the background color of the signature is
not the correct color even on the URL testcase, and the attached testcase.

Nivedita, 

this is definitely not fixed without the patch on windows 2000; build 2002-03-01-03.

Comment 19

[tor]

Comment on attachment 70257 [details] [diff] [review]
patch file for fixing the transparent animated gif

sr=tor

Comment 20

[Asa Dotzler [:asa]]

Comment on attachment 70257 [details] [diff] [review]
patch file for fixing the transparent animated gif

a=asa (on behalf of drivers) for checkin to the 0.9.9 branch and the 1.0 trunk

Comment 21

[Vinay Badami]

Fixed with chekin

on trunk
C:\mozilla\modules\libpr0n\src>cvs commit
cvs commit: Examining .
Checking in imgContainer.cpp;
/cvsroot/mozilla/modules/libpr0n/src/imgContainer.cpp,v  <--  imgContainer.cpp
new revision: 1.27; previous revision: 1.26
done

On 099 branch
C:\moz099\mozilla\modules\libpr0n\src>cvs commit
cvs commit: Examining .
Checking in imgContainer.cpp;
/cvsroot/mozilla/modules/libpr0n/src/imgContainer.cpp,v  <--  imgContainer.cpp
new revision: 1.26.2.1; previous revision: 1.26
done