Closed
Bug 106224
Opened 24 years ago
Closed 24 years ago
Fix for strict JS warning in editor.js
Categories
(SeaMonkey :: Composer, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: neil, Assigned: cmanske)
References
()
Details
Attachments
(1 file)
|
1.41 KB,
patch
|
cmanske
:
review+
kinmoz
:
superreview+
|
Details | Diff | Splinter Review |
Steps to reproduce problem:
1. Turn on strict JS warnings
2. Start Editor
3. Switch to HTML Source view
4. Make two edits
Actual results: Warning: useless expression
editor.js uses setAttribute("oninput", null) to "remove" the event handler.
Unfortunately this just replaces the event handler with a null event handler.
When this new event handler is compiled a strict JS warning results.
|
Reporter | |
Comment 1•24 years ago
|
||
|
|
Reporter | |
Updated•24 years ago
|
|
||
Comment 2•24 years ago
|
||
this is actually a dupe og bug 102504. But I dont care. As long as it's fixed...
|
|
||
Comment 3•24 years ago
|
||
*** Bug 102504 has been marked as a duplicate of this bug. ***
|
Assignee | |
Comment 4•24 years ago
|
||
Comment on attachment 54666 [details] [diff] [review]
Propsed patch
r=cmanske
Attachment #54666 -
Flags: review+
Attachment #54666 -
Flags: superreview+
|
|
Assignee | |
Updated•24 years ago
|
Assignee: syd → cmanske
|
|
Assignee | |
Comment 6•24 years ago
|
||
Taking bug - I'll check it in.
|
|
Assignee | |
Updated•24 years ago
|
Whiteboard: FIX IN HAND, reviewed
|
|
Assignee | |
Comment 7•24 years ago
|
||
checked in.
Neil, can you verify this is fixed? please mark verified-fixed..thanks.
|
||
Comment 10•24 years ago
|
||
This is really jst's fault, for compiling an empty string. For shame!
|
||
Updated•21 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•