106633 - Bad arguments in sprintf() prevent font download

Status: VERIFIED FIXED

(Core :: Internationalization, defect)

Description

[rbs]

I tried to visit http://www.taiwan.com and got an assertion about the failure of 
the font download service. I didn't even get to the point where the dialog pop 
up.

To investigate the problem, I placed an break point in 
nsFontMetricsWin::CheckFontLangGroup() to trace what was happening.

It turned out that CheckFontLangGroup() is passing "zh-TW" as fontpackageid:

         PR_snprintf(fontpackageid, sizeof(fontpackageid), lang3);
         res = proxy->NeedFontPackage(fontpackageid);

And further down, NeedFontPackage() leads to:

nsresult nsFontPackageHandler::CreateURLString(const char *aPackID, char **aURL)
{
  nsresult rv = NS_OK;

  NS_ASSERTION(aPackID, "illegal value- null ptr- aPackID");
  NS_ASSERTION(aURL, "illegal value- null ptr- aURL");

  if (strlen(aPackID) <= 5) <=== EARLY FAILURE HERE because length(zh-TW) <= 5
    return NS_ERROR_INVALID_ARG;

  [...]
}

Comment 1

[Frank Tang]

I think you introduce this bug see 
r 3.117 of nsFontMetricsWin.cpp

http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&ro
ot=/cvsroot&subdir=mozilla/gfx/src/windows&command=DIFF_FRAMESET&file=nsFontMetr
icsWin.cpp&rev2=3.117&rev1=3.116

It used to be 
sprintf(fontpackageid, "lang:%s", lang3);      
and you change it to
PR_snprintf(fontpackageid, sizeof(fontpackageid), lang3);   

so, origionally it is "lang:zh-TW" and you change it to "zh-TW". 
That is why the font download in the recent build does not work. 

Is r3.117 in the m0.9.4 branch ? if so , we may also want to fix that for m94
the length 5 checking is for "lang:"

Comment 2

[rbs]

Updating title to reflect the cause. Will a attach the one-liner fix.

Comment 3

[rbs]

Attachment: one-liner fix - seeking: r=ftang, sr=waterson, a=asa

The fix is not needed for the m0.9.4 since it wasn't affected by the changes.

Comment 4

[Chris Waterson]

Comment on attachment 57194 [details] [diff] [review]
one-liner fix - seeking: r=ftang, sr=waterson, a=asa

sr=waterson if ftang likes it

Comment 5

[Roy Yokoyama]

Comment on attachment 57194 [details] [diff] [review]
one-liner fix - seeking: r=ftang, sr=waterson, a=asa

/r=yokoyama

Comment 6

[rbs]

Checked in the trunk. Haven't heard from drivers re:suitability for m0.9.6
branch. Marking fixed and moving on.

Comment 7

[Christopher Blizzard (:blizzard)]

a=blizzard on behalf of drivers for 0.9.6

Comment 8

[rbs]

now fixed on the branch too.

Comment 9

[Teruko Kobayashi]

Verified.