106718 - "mail.smtpservers" gets corrupt

Status: VERIFIED WORKSFORME

(SeaMonkey :: MailNews: Account Configuration, defect)

Description

[Henrik Gemal]

just saw that my mail.smtpservers is looking like this in my prefs.js
user_pref
("mail.smtpservers", "smtp2,smtp2,smtp2,smtp2,smtp2,smtp2,smtp2,smtp2,smtp2,smtp
2,smtp2,smtp1,smtp2");

wow.. parhaps we should just strip dupes when we write the mail.smtpservers 
pref?

Comment 1

[Henrik Gemal]

this corruption can lead to the famous error message:
"sending of message failed"

after looking at the smtpservers line I found this:
user_pref("mail.smtpservers", "smtp1,smtp2,smtp1");

when removing the dupe smtp1 I could againg send mesages!

I think we could save a lot of users from gettting the sending of mesage failed 
error if this baby was fixed...

Comment 2

[scottputterman]

It sounds like this may be causing the problems we're seeing in 108892.  Can we
look into this?

Comment 3

[scottputterman]

Bhuvan, was this related to 108892?

Comment 4

[racham]

It may be ultimately linked to bug 108912 also as we have been allowing the
creation of smtp servers on empty server keys. Patch in that bug skips all such
creations and whenever there is a valid key that uniquely maps to a server.

Ninoschka, can you verify this bug also (if it can be reproduced with builds
dating back from today...try creating bunch of accounts, get into accountmanager
panel, click OK. Repeat it couple of times and keep a check on mail.smtpservers
pref in prefs.js) ? If he list grows as reported in the bug, please try with
tomorrow's build and update us.

Henrik,

can you let update the bug with all entries of the following format from your
prefs file and also let us know the identity of the account that you had
problems    with (OR if you don't mind, please send me/post your prefs.js file
in question).

("mail.identity.idX.smtpServer", "");

ref : in idX, X can range from 1....n (number of smtp server creations you might
have gone through). Also use tomorrow's build and update the bug if you still
see the problem.

thanks,
bhuvan.

Comment 5

[Henrik Gemal]

I've manually corrected the problem so I no longer have the prefs.js file with 
the problemed smtpservers.

Using build 20011108 I'm no longer able to reproduce the problem when I 
manually insert a dupe smtpserver so that I have:
user_pref("mail.smtpservers", "smtp1,smtp2,smtp1");

even though that mozilla doesn't remove the dupe entries in smtpservers. 
Perhaps it should do that.

Comment 6

[scottputterman]

It sounds like this isn't going to happen anymore.  I'm going to mark
Worksforme.  I'm not sure if we can get into this state still, but it might be
worthwhile to file a bug about fixing up the server list when there are dups.

Comment 7

[Henrik Gemal]

verified.

bug 117924 filed about stripping dupes in mail.smtpservers