106746 - Improper rendering of the DL/DT tag

Status: VERIFIED FIXED

(Core :: DOM: HTML Parser, defect, P1)

Description

[Joel Becker]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.2+) Gecko/20010720
BuildID:    2001102308 and 2001102508

Recent nightly builds are rendering the definition list elements (<DL>, <DT>,
and <DD>) incorrectly.  I recently decided to update my nightly, and evidenced
this problem with the builds 2001102308 and 2001102508.  The following HTML is
rendered incorrectly:

<DL>
<DT>Head 1</DT>
<DD>
Body 1
</DD>
<DT>Head 2</DT>
<DD>
Body 2
</DD>
</DL>

It should look like this:

Head 1
    Body 1
Head 2
    Body 2

The broken versions of Mozilla renders it thusly:

Head 1
    Body 1
    Head 2
    Body 2

Older versions (the 2001072008 build I've been using for a while now) and other
browsers (Every netscape and IE, of course) render it correctly.
Example source is available at http://jlbec.org/test/dt.html.

Reproducible: Always

Comment 1

[Boris Zbarsky [:bzbarsky]]

parser.  The <p> tags seem to be causing issues...

Comment 2

[Dawn Endico]

Attachment: test case

Comment 3

[Dawn Endico]

The problem here is that the parser is not closing the <dt> element when
it sees a <dd> as it should in quirks mode.

I see this problem in my oct 26 build but not in my Oct 21 pre 0.9.5 build.

dbaron calls this a pretty serious regression.

Comment 4

[Joel Becker]

Closing the DT tag isn't the only thing.  In my original test case
(jlbec.org/tests/dt.html), I explicitly include the </DT> tag, and it still
breaks on the second and subsequent elements.

Comment 5

[harishd]

My bad...I regressed this when fixing bug 102370. Targetting for 0.9.6.

Comment 6

[harishd]

Adding regression keyword that accidently got removed.

Comment 7

[harishd]

Attachment: patch v1.0 [ needs testing ]

Comment 8

[Brad Garcia]

More data.

Redhat 7.1, linux, x86

2001-10-10-21 was the last of the nightly builds that
I tried that did not have the problem (I try them
out roughly once a week).

2001-10-31-08 has the problem.

Here's a site that shows the problem.
Notice that "Entertainment", "News", and "Searching" should be alligned
with "Work":

    http://members.home.net/bgarcia/

Comment 9

[harishd]

Attachment: patch v1.2 [ much better patch ]

Comment 10

[harishd]

Comment on attachment 56273 [details] [diff] [review]
patch v1.2 [ much better patch ]

heikki says r=

Comment 11

[Marc Attinasi]

Comment on attachment 56273 [details] [diff] [review]
patch v1.2 [ much better patch ]

sr=attinasi

Comment 12

[harishd]

FIXED.

Comment 13

[Brad Garcia]

linux x86 2001-11-07-21

Problem still exists.
Is the fix not in yet?

Comment 14

[harishd]

I double checked with today's build ( 11/08 ) and it appears to be fixed.

Comment 15

[Brad Garcia]

linux x86 2001-11-09-06

NOT FIXED - PLEASE REOPEN

See this page:
    http://members.home.net/bgarcia/

Comment 16

[Boris Zbarsky [:bzbarsky]]

reopening.  The page Brad points to works fine in late september builds but not
in ones with this patch.

Comment 17

[Kevin McCluskey (gone)]

*** Bug 107072 has been marked as a duplicate of this bug. ***

Comment 18

[harishd]

Attachment: Testcase [ presence of FONT tag causes the problem ]

Comment 19

[harishd]

Attachment: patch v1.3

Comment 20

[harishd]

--> 0.9.7

Comment 21

[harishd]

Attachment: patch v1.4 [ Do not allow DD to contain DT and vice versa ]

Comment 22

[Johnny Stenback (:jst)]

Comment on attachment 60726 [details] [diff] [review]
patch v1.4 [ Do not allow DD to contain DT and vice versa ]

sr=jst

Comment 23

[Johnny Stenback (:jst)]

Comment on attachment 60726 [details] [diff] [review]
patch v1.4 [ Do not allow DD to contain DT and vice versa ]

sr=jst

Comment 24

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Comment on attachment 60726 [details] [diff] [review]
patch v1.4 [ Do not allow DD to contain DT and vice versa ]

r=heikki

Comment 25

[harishd]

FIXED.

Comment 26

[Moied]

Verified fixed with build 20020103 on Win2k and Linux.
fixed checked in cvs Version 3.135