Closed
Bug 106790
Opened 24 years ago
Closed 24 years ago
Need JS_ClearNewbornRoots()
Categories
(Core :: JavaScript Engine, defect, P1)
Core
JavaScript Engine
Tracking
()
VERIFIED
FIXED
mozilla0.9.6
People
(Reporter: epstein, Assigned: brendan)
Details
(Keywords: js1.5)
Attachments
(2 files)
|
1.01 KB,
patch
|
Details | Diff | Splinter Review | |
|
1.81 KB,
patch
|
brendan
:
review+
jband_mozilla
:
superreview+
|
Details | Diff | Splinter Review |
There needs to be a way for API users to clear the newborn roots of a context
to avoid having objects (strings, doubles) stick around if a context goes
unused for a while.
Patch coming up.
|
Reporter | |
Comment 1•24 years ago
|
||
|
|
||
Comment 2•24 years ago
|
||
I'd like to make the humble suggestion that a patch to the Spidermonkey APIDOC
source be made for this new funciton as well. (Or at least a comment in jsapi.h...)
|
|
||
Comment 3•24 years ago
|
||
Formally confirming bug for consideration -
Status: UNCONFIRMED → NEW
Ever confirmed: true
|
|
Assignee | |
Comment 4•24 years ago
|
||
Very cool -- only change I'll make is to make it void. This API is infallible,
no one should worry about it failing. Thanks for doing this.
/be
Status: NEW → ASSIGNED
Keywords: js1.5,
mozilla0.9.6
Priority: -- → P1
Target Milestone: --- → mozilla0.9.6
|
|
Assignee | |
Comment 5•24 years ago
|
||
|
|
Assignee | |
Comment 6•24 years ago
|
||
Comment on attachment 55170 [details] [diff] [review]
revised patch (big comment, void return)
r=brendan@mozilla.org
Attachment #55170 -
Flags: review+
|
|
||
Comment 7•24 years ago
|
||
Comment on attachment 55170 [details] [diff] [review]
revised patch (big comment, void return)
sr=jband
We should figure out how to use this from the DOM code.
Attachment #55170 -
Flags: superreview+
|
|
Assignee | |
Comment 8•24 years ago
|
||
Fix is in.
/be
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•