107055 - configure regression on BSD/OS 4.3

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect)

Description

[lidl]

I pulled from the tip of the CVS tree today, and configure no longer
completes on my BSD/OS 4.3 machine:

Fri Oct 26 19:09:42 EDT 2001
buildpid is 23092
Adding client.mk options from /homes/elves/lidl/.mozconfig:
    MOZ_OBJDIR=/data/obj/mozilla
cd /data/obj/mozilla
/scratch/proj/src/mozilla/configure
Adding configure options from /homes/elves/lidl/.mozconfig:
  --disable-debug
  --enable-crypto
  --disable-tests
  --enable-optimize=-O2 -mcpu=pentiumpro -march=pentium
  --with-libIDL-prefix=/usr/contrib/gnome
  --with-gdk-pixbuf-prefix=/usr/contrib/gnome
  --disable-pedantic
  --with-gtk
  --with-pthreads
  --with-jpeg
  --with-png
  --with-zlib
  --enable-xinerama
  --enable-nspr-autoconf
  --disable-xterm-updates
  --enable-double-buffer
  --disable-cpp-exceptions
creating cache ./config.cache
checking host system type... i386-pc-bsdi4.3
checking target system type... i386-pc-bsdi4.3
checking build system type... i386-pc-bsdi4.3
checking for gcc... gcc
checking whether the C compiler (gcc  ) works... yes
checking whether the C compiler (gcc  ) is a cross-compiler... no
checking whether we are using GNU C... yes
checking whether gcc accepts -g... yes
checking for c++... no
checking for g++... g++
checking whether the C++ compiler (g++  ) works... yes
checking whether the C++ compiler (g++  ) is a cross-compiler... no
checking whether we are using GNU C++... yes
checking whether g++ accepts -g... yes
checking for ranlib... ranlib
checking for as... /usr/bin/as
checking for ar... /usr/bin/ar
checking for ld... /usr/bin/ld
checking for strip... /usr/bin/strip
checking for dlltool... no
checking whether gcc and cc understand -c and -o together... yes
checking how to run the C preprocessor... gcc -E
checking how to run the C++ preprocessor... g++ -E
checking for a BSD compatible install... /usr/bin/install -c
checking whether ln -s works... yes
checking for gawk... gawk
checking for xemacs... no
checking for lemacs... no
checking for emacs... /usr/contrib/bin/emacs
checking for perl5... /usr/bin/perl5
checking for minimum required perl version >= 5.004... 5.00503
checking for full perl installation... yes
checking for whoami... /usr/bin/whoami
checking for autoconf... /usr/local/bin/autoconf
checking for unzip... /usr/contrib/bin/unzip
checking for zip... /usr/contrib/bin/zip
checking for makedepend... /usr/X11/bin/makedepend
checking for xargs... /usr/bin/xargs
checking for gmake... /usr/contrib/bin/gmake
checking whether /usr/contrib/bin/gmake sets ${MAKE}... yes
checking for X... libraries /usr/X11R6/lib, headers /usr/X11R6/include
checking for dnet_ntoa in -ldnet... no
checking for dnet_ntoa in -ldnet_stub... no
checking for gethostbyname... yes
checking for connect... yes
checking for remove... yes
checking for shmat... yes
checking for IceConnectionNumber in -lICE... yes
checking whether ld has archive extraction flags... yes
checking for working const... yes
checking for ANSI C header files... yes
checking for mode_t... yes
checking for off_t... yes
checking for pid_t... yes
checking for size_t... yes
checking for uid_t in sys/types.h... yes
checking for st_blksize in struct stat... yes
checking for int16_t... yes
checking for int32_t... yes
checking for int64_t... yes
checking for int64... no
checking for uint... yes
checking for uint_t... no
checking for uint16_t... no
checking for uname.domainname... no
checking for uname.__domainname... no
checking for 64-bit OS... no
checking for usable wchar_t (2 bytes, unsigned)... no
checking for compiler -fshort-wchar option... no
checking for dirent.h that defines DIR... yes
checking for opendir in -ldir... no
checking for sys/byteorder.h... no
checking for compat.h... no
checking for getopt.h... no
checking for sys/bittypes.h... no
checking for memory.h... yes
checking for unistd.h... yes
checking for gnu/libc-version.h... no
checking for nl_types.h... no
checking for X11/XKBlib.h... yes
checking for sys/statvfs.h... no
checking for sys/statfs.h... no
checking for sys/vfs.h... no
checking for sys/mount.h... yes
checking for sys/cdefs.h... yes
checking for gethostbyname_r in -lc_r... no
checking for atan in -lm... yes
checking for dlopen in -ldl... yes
checking for socket in -lsocket... no
checking for XDrawLines in -lX11... yes
checking for XextAddDisplay in -lXext... yes
checking for IceFlush in -lICE... yes
checking for SmcCloseConnection in -lSM... yes
checking for XtFree in -lXt... yes
checking for XineramaIsActive in -lXinerama... yes
checking for X11/extensions/Xinerama.h... yes
checking for XieFloGeometry in -lXIE... yes
checking for X11/extensions/XIElib.h... yes
checking for pthread_create in -lpthreads... no
checking for pthread_create in -lpthread... no
checking for pthread_create in -lc_r... no
checking for pthread_create in -lc... yes
configure: error: Option, pthreads, does not take an argument ().
*** Fix above errors and then restart with "gmake -f client.mk build"
gmake: *** [/data/obj/mozilla/Makefile] Error 1
Fri Oct 26 19:09:52 EDT 2001
23095: Terminated

This worked as recently as last night.

This would have shown up in the Tinderbox-Ports page, but the host
running BSD/OS 4.2 (otaku) was removed from that lineup a couple of
days ago.

The last couple of lines in the config.log are:

gcc -o dummy dummy.c    -I/usr/X11R6/include -lpthreads  -ldl -lm 
ld: cannot find -lpthreads
configure:6845: checking for pthread_create in -lpthread
gcc -o dummy dummy.c    -I/usr/X11R6/include -lpthread  -ldl -lm 
ld: cannot find -lpthread
configure:6867: checking for pthread_create in -lc_r
gcc -o dummy dummy.c    -I/usr/X11R6/include -lc_r  -ldl -lm 
ld: cannot find -lc_r
configure:6889: checking for pthread_create in -lc
gcc -o dummy dummy.c    -I/usr/X11R6/include -lc  -ldl -lm

Comment 1

[hacker formerly known as [e-mail]]

Turned out to be a long standing bug in the MOZ_ARG macros that we use to
auto-generate the webconfigurator page.  Restarted otaku too.

Comment 2

[hacker formerly known as [e-mail]]

Attachment: Tell base TWO_STRINGS macro which variable to check user args against

Comment 3

[lidl]

Is this going to get check into the CVS tree anytime soon?

As far as I'm concerned this is still busted on the trunk.
(Quite honestly, I don't understand why otaku works and my
machine fails...)

I applied that patch to the relevant file, but cannot get "autoconf"
to run on my machine -- I probably need to get more of the auto*
utilities from the gnu project to make that work.

Or, can you attach the configure script generated with this patch
to this bug, so I can attempt that?

Comment 4

[hacker formerly known as [e-mail]]

Well, I was waiting for verification before I checked it in.  otaku doesn't hit
this problem because it doesn't use --with-pthreads. If you're having problems
with autoconf, it may be because you're using autoconf 2.5x and mozilla doesn't
work with it.

Comment 5

[hacker formerly known as [e-mail]]

Attachment: configure script with altoptions.m4 changes

Comment 6

[hacker formerly known as [e-mail]]

*** Bug 107408 has been marked as a duplicate of this bug. ***

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

BSD is totally busted.  BTW, I made the exact same patch (more or less) in
107408 before it was duped to this.  Please check in ASAP; I'd mark this as blocker.

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

BTW, as I suspect you know, it breaks considerable more than just the BSD builds.

Comment 9

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 55345 [details] [diff] [review]
Tell base TWO_STRINGS macro which variable to check user args against

r=[e-mail].  I also checked the autoconf output

Comment 10

[lidl]

For what it is worth, the attachement to this bug that is the
configure script works for me.  So, I was able to get mozilla
built today using that version of the configure script.

So, if you were looking for feedback from me (which I doubt),
now you know.

Comment 11

[hacker formerly known as [e-mail]]

Ok, ok, ok. It's in. :)

Comment 12

[Tracy Walker [:tracy]]

verified