107087 - Parser should have category listeners

Status: VERIFIED FIXED

(Core :: DOM: HTML Parser, defect, P2)

Description

[Doug Turner (:dougt)]

Right now, the char detector is loaded by the app startup code.  When this
module loads, the first thing that it does is creates the parser service (which
loads the parser module/dll) only to register a listener!

It would be better if the parser service could notify any category listeners
before the service calls out to its registered listeners.

Here is the patch...

Comment 1

[Doug Turner (:dougt)]

Attachment: creates parser-service category

Comment 2

[Doug Turner (:dougt)]

The reason for this is simple.  We want to delay library loading as long as we
can.  

Right now, chardet.dll loads as the third library in mozilla.  The first thing
that it does is, as I stated above, creates the parser service to register with
it.  The chardet also loads the uchar.dll.

With this patch, uconv.dll is delayed until it is required of by profile to do a
case compare. THe chardet.dll is loaded very late, right before the parser
service notifies its registered listeners.

harishd, can you take a look at this patch?

Comment 3

[Doug Turner (:dougt)]

this may help startup time by delaying the parser from loading so early

Comment 4

[Alec Flett]

Comment on attachment 55355 [details] [diff] [review]
creates parser-service category

looks good, except that you're not unregistering the category if the dll is 
being uninstalled. (I realize that it never did before, but we should fix 
that now - it's only a few lines of code :))

Comment 5

[harishd]

As alecf mentioned we need to unregister category. --> 0.9.8

Comment 6

[harishd]

Out of time. Mass move to 0.9.9

Comment 7

[harishd]

Attachment: patch v1.1 [ includes category unregistration ]

Comment 8

[Alec Flett]

Comment on attachment 67496 [details] [diff] [review]
patch v1.1 [ includes category unregistration ]

excellent - thanks for the unreg procedures!
sr=alecf

Comment 9

[harishd]

Comment on attachment 67496 [details] [diff] [review]
patch v1.1 [ includes category unregistration ]

r=harishd ;) Since the patch is originally from dougt and I just added the
unreg. proc.

Comment 10

[harishd]

Fix is in.

Comment 11

[Moied]

Verified fix checked in cvs (Rev 3.4)