Closed Bug 107087 Opened 23 years ago Closed 22 years ago

Parser should have category listeners

Categories

(Core :: DOM: HTML Parser, defect, P2)

x86
Windows 2000
defect

Tracking

()

VERIFIED FIXED
mozilla0.9.9

People

(Reporter: dougt, Assigned: harishd)

Details

(Keywords: perf, Whiteboard: [fix in hand])

Attachments

(2 files)

Right now, the char detector is loaded by the app startup code.  When this
module loads, the first thing that it does is creates the parser service (which
loads the parser module/dll) only to register a listener!

It would be better if the parser service could notify any category listeners
before the service calls out to its registered listeners.

Here is the patch...
The reason for this is simple.  We want to delay library loading as long as we
can.  

Right now, chardet.dll loads as the third library in mozilla.  The first thing
that it does is, as I stated above, creates the parser service to register with
it.  The chardet also loads the uchar.dll.

With this patch, uconv.dll is delayed until it is required of by profile to do a
case compare. THe chardet.dll is loaded very late, right before the parser
service notifies its registered listeners.

harishd, can you take a look at this patch?
this may help startup time by delaying the parser from loading so early
Keywords: perf
Comment on attachment 55355 [details] [diff] [review]
creates parser-service category

looks good, except that you're not unregistering the category if the dll is 
being uninstalled. (I realize that it never did before, but we should fix 
that now - it's only a few lines of code :))
Status: NEW → ASSIGNED
Priority: -- → P2
Target Milestone: --- → mozilla0.9.7
Whiteboard: [fix in hand]
As alecf mentioned we need to unregister category. --> 0.9.8
Target Milestone: mozilla0.9.7 → mozilla0.9.8
Out of time. Mass move to 0.9.9
Target Milestone: mozilla0.9.8 → mozilla0.9.9
Comment on attachment 67496 [details] [diff] [review]
patch v1.1 [ includes category unregistration ]

excellent - thanks for the unreg procedures!
sr=alecf
Attachment #67496 - Flags: superreview+
Comment on attachment 67496 [details] [diff] [review]
patch v1.1 [ includes category unregistration ]

r=harishd ;) Since the patch is originally from dougt and I just added the
unreg. proc.
Attachment #67496 - Flags: review+
Fix is in.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Verified fix checked in cvs (Rev 3.4)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: