107151 - improve addressbook performance.

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[(not reading, please use [e-mail] instead)]

improve addressbook performance.

starting with cleaning up our datasources, cleaning up our CSS, and switching 
to outliner.

stephend, do you have any perf numbers for addressbook up publicly?

if so, can you add a link here?

Comment 1

[(not reading, please use [e-mail] instead)]

found it.

http://www.mozilla.org/mailnews/performance/abookperf.html

known bugs to fix first:

http://bugzilla.mozilla.org/show_bug.cgi?id=53111 (list icon in results pane)
http://bugzilla.mozilla.org/show_bug.cgi?id=105835 (clean up tree.css in 
classic skin)
http://bugzilla.mozilla.org/show_bug.cgi?id=73868 (switch to outliner)

Comment 2

[R.K.Aa.]

bug 100281 is noteworthy
http://bugzilla.mozilla.org/show_bug.cgi?id=100281

Comment 3

[Chase Tingley]

bug 105783 could help a lot here; depends on your timeframe though (i'm hoping
to have first cut done this week).

Comment 4

[Chase Tingley]

To follow up on that, I ran a quick test on the time it took to display the
"Collected addresses" pane the first time (100 addresses total).  The cleaned up
sorting code I have in my tree sped it up by about 25% compared to the original
code -- from 400k microseconds to 300k.

Comment 5

[Chase Tingley]

Argh, no, this is not correct.  These are only times spent in
nsXULContentBuilder::CreateContainerContents().  This is usually a sizeable
chunk of the total time, but I don't have the real numbers here.

Comment 6

[(not reading, please use [e-mail] instead)]

the XUL sort service changes will not affect addressbook too much.

I'm going to be switching the results pane over to a pure nsIOutlinerView, so 
I'll be doing the sorting myself, similar to what we do nsMsgDBView.cpp

Comment 7

[(not reading, please use [e-mail] instead)]

I've landed some css fixes to addressPane.css which will help perf.

Comment 8

[(not reading, please use [e-mail] instead)]

there are still performance issues, but I'm going to claim victory on this bug, 
and open new bugs for the specific issues.

stephend, when you have some time could you re-run the tests at
http://www.mozilla.org/mailnews/performance/abookperf.html

edit card and new card will still be slow, but the other items should have 
gotten much faster.

Comment 9

[[e-mail] (gone - use [e-mail] instead)]

Attachment: Address book performance (has been uploaded to the url above)

Comment 10

[[e-mail] (gone - use [e-mail] instead)]

Verified FIXED.  I'll start to spin up individual bugs now that Outliner has landed.

Here is the breakdown by area:

60% improvement in sort by name
62% improvement in sort by email
37% improvement in address book load time
88% improvement in scrolling

No improvement in Edit Card or New Card (but Seth knew this).