108282 - gtk_widget_hide called with NULL, crashes installer on clicking install button

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect)

Description

[Nidheesh Dubey]

From Bugzilla Helper:


The code in mozilla/xpinstall/wizard/unix/src2/nsInstallDlg.cpp calls
gt_widget_hide on NULL if all xpi's are locally available and are NOT REQUIRED
TO BE DOWNLOADED. On clicking install button under gtk 1.2.10 this shows up as
installer crash. Method InitInstallProgress assumes that sDLProgressbar.vbox is
a valid created widget (done in InitDLProgress if download is required.)

nsInstallDlg::InitInstallProgress()
{
    gtk_widget_hide(sDLProgress.vbox);
    gCtx->idlg->ShowTable();
}

This code should be changed to 
if (sDLProgress.vbox)
	gtk_widget_hide(sDLProgress.vbox);

and the crash goes away. In gtk 1.2.6 this does not show up. Nonethless this is
a simple fix and the caller of gtk_widget_hide can also correct the code and not
just assume that toolkit will take care.

Reproducible: Always
Steps to Reproduce:
1.run mozilla-installer and keep all xpi pkgs in the subdirectory xpi. (copy
them locally)
2.choose install location etc and hit install. 
3.if you have 1.2.10 supplied in Solaris it crashes in InstallProgress

Actual Results:  crashes in InstallProgress with null parameter

Expected Results:  install should go thru without needing any download

Comment 1

[Syd Logan]

Attachment: patch

Comment 2

[Syd Logan]

Attachment: patch

Comment 3

[Syd Logan]

Attachment: patch

Comment 4

[Brian Ryner (not reading)]

Comment on attachment 68259 [details] [diff] [review]
patch

r=bryner

Comment 5

[Daniel Veditz [:dveditz]]

Comment on attachment 68259 [details] [diff] [review]
patch

sr=dveditz

Comment 6

[Syd Logan]

fixed

Comment 7

[K'Trina Medina]

Verified code fix