108939 - Fonts: make a change, panel contents become horked

Status: VERIFIED FIXED

(SeaMonkey :: Preferences, defect, P1)

Description

[Rafael Ebron (:rebron)]

Using  Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.5+) Gecko/20011107
Netscape6/6.1b1

Expected results: Default preferences should be Western.
Actual results: Font preference is blank and defaults pixel size of 8 pixels
rendering MSN.com and other sites to have small font.
When changing to Western, and selecting OK, pref is not saved.

Comment 1

[Brian Nesse (gone)]

I noted this in another bug somewhere... don't recall where. I first noticed
this on Monday (the 5th). I assume a checkin over the weekend broke it, but I
don't know for certain.

Comment 2

[Brian Nesse (gone)]

As far as I can tell, it seems that the point size prefs are saved, but they are
somehow keyed to font preference. When I go to the panel, it is confused, but if
I select "Western" it automatically selects the point sizes that I had choosen
for "western"... Seems like the menu isn't initialized correctly, but the
underlying data is there.

Comment 3

[Brian Nesse (gone)]

Also now when I go to the prefs pane for fonts I see a whole bunch of:

chrome://communicator/content/pref/pref-fonts.js line 87: reference to undefined
property aDataObject.languageData

JS warnings.

Comment 4

[Samir Gehani]

-> jbetak?  Bounce back as needed.

Comment 5

[Olga]

On Mac OSX I see the same problem: in Pref, Message Display, Fonts, 'Fonts for'
field does not keep previous selection. Also other fields restore some kind of
default settings.
You selected: 'Fonts for':Western, 'Proportional':Serif, Size:20, all other
fields:Arial. Click OK to save settings.
Next time you check your setting: 'Fonts for' is blank, other fields
show:American Typewriter, size:8.

Comment 6

[Jason A.]

The same happens here, build Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9.5+)
Gecko/20011111.

From the default settings, i change courier new to andale mono.

When I return later, I find this:

[no encoding selected]
serif [8 pt]
centaur
[no sans-serif font]
brush script mt
[no fantasy font]
lucida sans typewriter [8 pt]


This does not affect rendering, ie monospace is displayed with andale mono,
serif with times new roman etc.. Re-selecting the encoding to Western  restores
everything, including my earlier changes.

Comment 7

[sairuh (rarely reading bugmail)]

using 2001.11.08.08-comm bit on linux, i tried the following:

1. went to the Appearance > Fonts pref panel.
2. changed my serif font from new century schoolbook to times.
3. click OK --prefs dlg dismised and the font style was updated in the browser.
4. return to same pref panel.

results: noticed that *all* five font family droplists now display courier!

would this be the same problem?

ian/marc, any idea who ought to get this?

Comment 8

[Marc Attinasi]

From the comments, it sounds like the actual underlying prefs are correct, it is
just the display. In that case, I have no useful knowledge about this because it
is likely a UI issue. It is probably wiorht checking the pref files to make sure
that it is just a UI issue, but since the rendering of the fonts looks correct I
am guessing it is.

Comment 9

[Brian Nesse (gone)]

cc'ing waterson. Chris, do you think this might be somehow related to the same
changes that caused the search-panel.js regressions?

Comment 10

[sairuh (rarely reading bugmail)]

okay, this is what i'm seeing using 2001.11.14-comm bits on linux [rh6.2], winnt
and mac os 10.1. i've clarified the summary --but do let me know if this current
behavior should be spun off into another bug...

0. create a new profile.
1. load http://www.yahoo.com/ --it's a good page for vieiwing font changes.
2. open Prefs dlg, go to Fonts panel.
3. change a font setting --what i did was change the "serif" font; eg, on linux,
i went from from Times to New Century.
4. click OK to save and dismiss Prefs.
5. observe that the font style has updated on the web page.
6. go back to the Fonts pref panel.

results:
a. the language menulist is now blank, rather than listing Western.
b. notice that the values of the five font family menulists have changed. [exact
values differ per platform.]
c. if you dropdown any of those five menulists, the contents there have changed
as well!  [again, exact values differ per platform.] no longer have access to
the previously available font choices.

i'll attach screenshots i've made when using the linux build...

due to (c), i'm bumping this up to critical, as the user is no longer provided
with the same or as many choices.

side note: haven't yet thoroughly tested the cases, but changing "sans-serif"
also had the same effect. am guessing that changing any of the other three font
family styles would result in the same behavior, yes?

Comment 11

[sairuh (rarely reading bugmail)]

Attachment: Fonts panel, before any changes

Comment 12

[sairuh (rarely reading bugmail)]

Attachment: displaying font droplist before making a change

Comment 13

[sairuh (rarely reading bugmail)]

Attachment: Fonts panel after making a change

Comment 14

[sairuh (rarely reading bugmail)]

Attachment: displaying font droplist after making a change

Comment 15

[sairuh (rarely reading bugmail)]

*** Bug 110122 has been marked as a duplicate of this bug. ***

Comment 16

[sairuh (rarely reading bugmail)]

not sure how useful this'd be, but i've included js console output below...

before any font changes [just when selecting the Fonts panel:

Warning: reference to undefined property aDataObject.languageData
Source File: chrome://communicator/content/pref/pref-fonts.js
Line: 87

Warning: reference to undefined property aDataObject.currentLanguage
Source File: chrome://communicator/content/pref/pref-fonts.js
Line: 88

Warning: reference to undefined property aDataObject.dataEls
Source File: chrome://communicator/content/pref/pref-fonts.js
Line: 96

Warning: reference to undefined property aDataObject.fontDPI
Source File: chrome://communicator/content/pref/pref-fonts.js
Line: 117

Warning: reference to undefined property aDataObject.useDocFonts
Source File: chrome://communicator/content/pref/pref-fonts.js
Line: 137

Warning: reference to undefined property languageData[languageList.value]
Source File: chrome://communicator/content/pref/pref-fonts.js
Line: 367

Warning: assignment to undeclared variable prefvalue
Source File: chrome://communicator/content/pref/pref-fonts.js
Line: 183



after making font change [there were no console msgs during change or after
OK/dismiss dlg], i got the same as above, plus:

Warning: reference to undefined property element.getElementsByAttribute("value",
prefvalue)[0]
Source File: chrome://communicator/content/pref/pref-fonts.js
Line: 109

Comment 17

[Frank Tang]

jbetak's contract is up. Bulk move bugs to ftang

Comment 18

[Frank Tang]

rchen- can you help to look at this one. UI related issue. Ask nhotta to help you.

Comment 19

[Frank Tang]

mark m0.9.7 P1

Comment 20

[John Fredlund]

Can bug 24830 be marked as a duplicate of this?

Comment 21

[sairuh (rarely reading bugmail)]

*** Bug 111138 has been marked as a duplicate of this bug. ***

Comment 22

[R.K.Aa.]

*** Bug 111270 has been marked as a duplicate of this bug. ***

Comment 23

[sairuh (rarely reading bugmail)]

*** Bug 111358 has been marked as a duplicate of this bug. ***

Comment 24

[Brad Tiffany]

Attachment: Patch to explicity set prefattribute="value" on language selection menulist

It appears that the changes one makes in the font prefs panel aren't being
properly saved.  If you look at prefs.js for a profile for which you've messed
up the font panel, you'll see the bogus entry:

user_pref("font.language.group", "[object Window]");

After some testing, it appears to me that savePrefs (at the very least) in
nsPrefWindow.js is not able to correctly recognize that the language-group
("Fonts for:") popup is a menulist and thus does not automatically assign it
_any_ prefattribute.  I don't know what's happening in pref-fonts.js that
causes this, but I did discover that assigning prefattribute="value" explicity
masks the problem (such an explicit assignment was removed during the XUL
shakeup earlier this month).  After applying the attached patch, I could run
mozilla with a spoiled profile, open the font prefs panel, change the
"Fonts-for" popup from blank to Western, and have the results stick, with
all.js showing the correct entry

user_pref("font.language.group", "x-western");

Comment 25

[R.K.Aa.]

*** Bug 112351 has been marked as a duplicate of this bug. ***

Comment 26

[R.K.Aa.]

*** Bug 112407 has been marked as a duplicate of this bug. ***

Comment 27

[Brian Nesse (gone)]

Hmm, just looked over Brad's patch (and comments) more closely. The change he
refers to was checked in by blake on Nov 2nd, about the time this broke. ->blake

Comment 28

[Samir Gehani]

*** Bug 112856 has been marked as a duplicate of this bug. ***

Comment 29

[sairuh (rarely reading bugmail)]

*** Bug 112907 has been marked as a duplicate of this bug. ***

Comment 30

[R.K.Aa.]

*** Bug 113182 has been marked as a duplicate of this bug. ***

Comment 31

[Samir Gehani]

*** Bug 113631 has been marked as a duplicate of this bug. ***

Comment 32

[Alexander Skwar]

Using builds 2001120508 on Linux and 2001120504 on Windows 2000, changing the
fonts, closing prefs and going back to font settings, shows a blank for the
"Fonts for:" setting.

Further, on the Windows build, it's not possible to set a font for "Fantasy" if
"Western" is selected.  However, the Linux build allows to set a font for
Fantasy @ Western.  Dunno which one is wrong, but it should behave identically.

Comment 33

[R.K.Aa.]

*** Bug 113668 has been marked as a duplicate of this bug. ***

Comment 34

[Boris Zbarsky [:bzbarsky]]

*** Bug 113814 has been marked as a duplicate of this bug. ***

Comment 35

[R.K.Aa.]

the pref fpr "Fonts for.." now sticks on a current CVS build, Linux.
But when selecting "fonts" in prefs, i see JS warnings and preferences can not
be closed with OK button.

This appears in console by merely clicking prefs/fonts:

Warning: reference to undefined property aDataObject.languageData
Source File: chrome://communicator/content/pref/pref-fonts.js
Line: 87
(repeated one more time)

Warning: reference to undefined property aDataObject.currentLanguage
Source File: chrome://communicator/content/pref/pref-fonts.js
Line: 88
(repeated one more time)

Warning: reference to undefined property aDataObject.dataEls
Source File: chrome://communicator/content/pref/pref-fonts.js
Line: 96
Warning: reference to undefined property aDataObject.dataEls
Source File: chrome://communicator/content/pref/pref-fonts.js
(repeated 3 more times)

Warning: reference to undefined property aDataObject.fontDPI
Source File: chrome://communicator/content/pref/pref-fonts.js
Line: 117
(repeated one more time)

Warning: reference to undefined property aDataObject.useDocFonts
Source File: chrome://communicator/content/pref/pref-fonts.js
Line: 137
(repeated once more)

Warning: reference to undefined property languageData[languageList.value]
Source File: chrome://communicator/content/pref/pref-fonts.js
Line: 367
(repeated 9 more times)

Warning: assignment to undeclared variable prefvalue
Source File: chrome://communicator/content/pref/pref-fonts.js
Line: 183

Error: invalid 'in' operand itemObject
Source File: chrome://communicator/content/pref/nsPrefWindow.js
Line: 198

Comment 36

[R.K.Aa.]

sorry - forgot:
warnings above are accompanied by 36 lines in the xterm moz was started from:

Warning prev sibling is not in our list!!!

Comment 37

[R.K.Aa.]

*** Bug 114613 has been marked as a duplicate of this bug. ***

Comment 38

[R.K.Aa.]

font prefs OK button failing: new bug 114630

Comment 39

[R.K.Aa.]

Testing with Linux CVS, checkins through 12/11/2001 20:18
New profile, classic and modern theme:

When clicking fonts in preferences:

1: "Fonts for: .." are now showing Western at startup
2: The dialog can be dismissed again right away by clicking OK button
3: Changing any font or size selection: correct font and size takes effect
4: When opening prefs again, eventual modifications are displayed as they should
5: Syntax used in prefs.js also correct - no funny stuff.
6: Old profile works like charm as well.

(Sidenote: Some JS warnings appear when strick warnings are turned on in debug
prefs. They may not have a thing to do with this bug - never really looked at
them before.)

In all practical respects this bug is now fixed.

Comment 40

[Blake Ross]

marking fixed.

Comment 41

[sairuh (rarely reading bugmail)]

looks good --tested by changing the font size and serif font name [family]. vrfy
fixed, using comm bits [2002.01.07.0x] on linux rh7.2, winnt and mac 10.1.2.