109107 - investigate and improve nsAbCollecter::CollectAddress() perf

Status: VERIFIED INVALID

(SeaMonkey :: MailNews: Address Book & Contacts, defect, P2)

Description

[(not reading, please use [e-mail] instead)]

investigate and improve nsAbCollecter::CollectAddress() perf

I see some things that look suspect, but I don't have quantify numbers yet to
know how much it costs us.

//remove card from ab, and
m_historyAB->DeleteCard( existingCard, PR_TRUE );
SetNamesForCard(existingCard, curName);
//append it to the bottom.
rv = AddCardToCollectedAddressBook(existingCard);
NS_ENSURE_SUCCESS(rv,rv);

if you see badness, please wait for me to land #73868, to avoid conflicts.

Comment 1

[Scott MacGregor]

I haven't been waiting long enough before stopping my quantify log for the timer
to go off and add the message to the collected address book. This doesn't really
show up as a perf hit for message display because of the timer. The message is
usually already displayed before the timer goes off to add the address to the CAB.

next time I do a run I can wait till it goes off to tell you how long it is taking.

Comment 2

[scottputterman]

nsbeta1+ for investigation and fixing if anything shows up.

Comment 3

[Scott MacGregor]

This really isn't too much of an issue with message display anymore because I
moved it to a 2 second timer. Moving out. 

Comment 4

[scottputterman]

moving out because message display investigation is on hold for a while.  Moving
to future based on mscott's last comments.  If we want to investigate this
later, we can move it back in.

Comment 5

[Scott MacGregor]

this is now invalid. we never collect addresses from read messages, only from
messages you reply to.

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

verified