109488 - Collapse the all-*.rdf and user-*.rdf files into one file

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[David Hyatt]

This bug covers taking the chrome registry RDF files and simplifying the code by
merging all the RDF files together.

Comment 1

[David Hyatt]

Targeting for 0.9.7.  Adding perf keyword.

Comment 2

[David Hyatt]

Attachment: Patch to collapse the files

Comment 3

[David Hyatt]

This patch collapses all of the all-* and user-*.rdf files into two files, one 
in the profile and one in the install dir.  In a typical usage scenario, the 
user's skin/locale selections (once they start switching skins etc.) are kept 
in the profile file, and everything else is basically in the chrome file.

Comment 4

[David Hyatt]

Attachment: Patch to also remove support for stylesheets.rdf, since it isn't used by anyone.

Comment 5

[David Hyatt]

Actually I changed my mind about removing this feature.  If I do what I was 
talking about with dp (storing info in chrome.rdf about whether or not your 
package has stylesheets or overlays), then I can stop the file misses without 
sacrificing the feature.

Comment 6

[Chase Tingley]

would it be a better idea to hold mBatchInstallFlushes in some automatic helper
class, in case you bail out halfway due to some freaky failure?

Comment 7

[David Hyatt]

I doubt it matters, since any freaky failure in the middle of chrome
registration will probably be fatal anyway. :)

Comment 8

[Suresh Duddi (gone)]

Comment on attachment 58580 [details] [diff] [review]
Patch to also remove support for stylesheets.rdf, since it isn't used by anyone.

r=dp

Comment 9

[David Hyatt]

Attachment: Revised patch. dp reviewed this.

Comment 10

[Brendan Eich [:brendan]]

Comment on attachment 58591 [details] [diff] [review]
Revised patch.  dp reviewed this.

rubbery sr=[e-mail], the chrome registry code still seeks kinda fast
and loose, but more power to it for not being bloated with error handling junk!

/be

Comment 11

[Marek Wawoczny]

Fixing this bug broken my idea for default settings (settings for skin and locale) in localized builds. By editing user-locales.rdf and user-skins.rdf files  and copying them to \Mozilla.org\Mozilla\chrome\ dir I could set default skin / locale.
In this way any new profile was with Modern skin and Polish language. Now this feature is broken and new profile has Classic skin and English language by default. I can't also edit chrome.rdf  because this is Mozilla generate file. So I'm asking for re-enabling reading user-locales.rdf and user-skins.rdf only in \Mozilla.org\Mozilla\chrome or creating for example user-chrome.rdf file with user settings. I'm attaching edited user-locales.rdf and user-skins.rdf files.

Comment 12

[Marek Wawoczny]

Attachment: Edited user-locales.rdf with pl-PL locale.

Comment 13

[Marek Wawoczny]

Attachment: Edited user-skins.rdf with Modern skin.

Comment 14

[David Hyatt]

You can define a chrome.rdf file in your profile that contains your locale/skin
settings.

Comment 15

[Marek Wawoczny]

First:
This wont setup localized and skined Profile Manager (will be always in English and with Classic skin)

Second:
When I making localized builds (*.exe, *.tar.gz) I want that my locale would be default, for example newbie user is installing mozilla, then Profile Manager is started with PL locale and Modern skin, newly created profile is also in PL locale and Modern skin (it was working before). With this changes to this bug newbie is installing localized version, but first thought is "This is localized version but why Profile Manger is in English" and "Why my new profile is in English" :((((

Comment 16

[David Hyatt]

You can edit chrome.rdf in either the install or profile to get the settings you
need.  No features have been lost here.  All I did was collapse all-*.rdf and
user-*.rdf into a single file.  You can still put the same information into the
rdf file that was in all-* or user-*.

Comment 17

[Marek Wawoczny]

Did I said that this files (user*) were copied (to \Mozilla.org\Mozilla\chrome\) during localized build installation (this must be automated process, newbie user shouldn't edit chrome as You suggested)? But I've already tested it and I put info about locale and skin into chrome.rdf (and nothing more) and if this file will be copied to \Mozilla.org\Mozilla\chrome\ during installation all post installation changes into registry will be added to this file (Thats ok - everything seems fine). But really don't know what will happen if user who already have Mozilla will install only langpack (with preedited chrome.rdf) - will registry be overvritten, added, or nothing will change or Mozilla will crash?

Comment 18

[Neil Pryde]

Eh David, the MultiZilla installation doesn't work after this change. What do I
need to change in order to get it going again? 

Thanks,
-Neil.

Comment 19

[Daniel Veditz [:dveditz]]

Marek, what you need is bug 54904 (ability to select default skin in an
install). Overwriting the user-* files was never the right way to do it, but now
that the hack workaround has been taken away the importance of bug 54904 is much
higher. Please lobby/vote in that bug.

Comment 20

[Marek Wawoczny]

Thnx for info about 54904 bug.