109629 - [prefs] can't add languages

Status: VERIFIED FIXED

(SeaMonkey :: Preferences, defect, P2)

Description

[chado]

reproduce:
 1. Open Preferences | Navigator | Languages.
 2. Click "Add..." button.
 3. Choose any language, then click "OK".

expected result:
 Choosen language appears in "Languages in order..." area.

actual result:
 Choosen language doesn't appear.

reproducible: always.

build:
 mac 2001-11-05-16-trunk and after can't add languages.
 mac 2001-11-01-08-trunk and before can add languages.
 win 2001-11-05-03-trunk and after can't add languages.
 win 2001-11-01-03-trunk and before can add lanfuages.

additional info: 
 I tried to try on win 2001-11-02-09-trunk, 
 but opening pref for lang caused crash. 

theme:
 On both of classic and modern.

Comment 1

[Christian Schmidt]

I see this as well using Mozilla/2001110603 on Win2000.

However, if I double click on a language instead of pressing OK, then it works 
as expected.

Comment 2

[Boris Zbarsky [:bzbarsky]]

ccing hewitt since this may be fallout from the <dialog> landing.

Comment 3

[Samir Gehani]

The call to doSetOKCancel(AddAvailableLanguage) was removed from
pref-languages.js but is not called from anywhere now.  Patch coming up.

Comment 4

[Samir Gehani]

Attachment: Specify ondialogaccept handler.

Comment 5

[Samir Gehani]

hewitt, please r.
blake, please sr.

Comment 6

[Samir Gehani]

Attachment: Patch rev 2: *return* AddAvailableLanguage so false is propagated in alert conditions. Thanks to Blake for pointing this out.

Comment 7

[Blake Ross]

Comment on attachment 57870 [details] [diff] [review]
Patch rev 2: *return* AddAvailableLanguage so false is propagated in alert conditions.  Thanks to Blake for pointing this out.

sr=blake

Comment 8

[Brian Ryner (not reading)]

Comment on attachment 57870 [details] [diff] [review]
Patch rev 2: *return* AddAvailableLanguage so false is propagated in alert conditions.  Thanks to Blake for pointing this out.

r=bryner

Comment 9

[Samir Gehani]

Checked in.

Comment 10

[R.K.Aa.]

*** Bug 110481 has been marked as a duplicate of this bug. ***

Comment 11

[R.K.Aa.]

Did this make it into 0.9.6? bug 111566 and bug 111570 were just filed

Comment 12

[Boris Zbarsky [:bzbarsky]]

*** Bug 111566 has been marked as a duplicate of this bug. ***

Comment 13

[R.K.Aa.]

*** Bug 111668 has been marked as a duplicate of this bug. ***

Comment 14

[Alfonso Martinez]

*** Bug 111721 has been marked as a duplicate of this bug. ***

Comment 15

[sairuh (rarely reading bugmail)]

vrfy fixed using 2001.11.28.0x-comm bits on linux rh7.2, mac 10.1.1 and winNT.

Comment 16

[Boris Zbarsky [:bzbarsky]]

*** Bug 112594 has been marked as a duplicate of this bug. ***

Comment 17

[R.K.Aa.]

*** Bug 113040 has been marked as a duplicate of this bug. ***

Comment 18

[R.K.Aa.]

*** Bug 113135 has been marked as a duplicate of this bug. ***

Comment 19

[Matthias Versen [:Matti]]

*** Bug 113379 has been marked as a duplicate of this bug. ***

Comment 20

[R.K.Aa.]

*** Bug 114417 has been marked as a duplicate of this bug. ***

Comment 21

[R.K.Aa.]

*** Bug 115062 has been marked as a duplicate of this bug. ***