Closed
Bug 109703
Opened 23 years ago
Closed 21 years ago
Proxy: installer sends auth even w/o entering username+password
Categories
(SeaMonkey :: Installer, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.7alpha
People
(Reporter: hurtta+mozilla, Assigned: opi)
References
Details
Attachments
(2 files)
|
474.77 KB,
text/plain
|
Details | |
|
1.22 KB,
patch
|
darin.moz
:
review+
|
Details | Diff | Splinter Review |
From Bugzilla Helper: User-Agent: Mozilla/4.75 [en] (X11; U; Linux 2.2.16-9mdk i686) BuildID: Linux talkback anabled build installer for 0.9.5 fails when using proxy settings (I was using http proxy). It starts loading parts and then report about some CRC error. Installer is from page http://www.mozilla.org/releases/ Link is http://ftp.mozilla.org/pub/mozilla/releases/mozilla0.9.5/mozilla-i686-pc-linux-gnu-0.9.5-installer.tar.gz Reproducible: Always Steps to Reproduce: 1. Run # /usr/people/hurtta/mozilla/mozilla-installer/mozilla-installer 2. Click Next 3. Click Accept 4. Change Destination directory to /data/mozilla 5. Click Next 6. Clcik proxy Settings... Set proxy Host and proxy port 7. Click Ok and Install (without setting a proxy installer just dumps core. In that case it does not have http access.) Actual Results: Mozilla installer window: Downloading: ftp://ftp.mozilla.org/p...mozilla0.9.5/linux-xpi/ To: /usr/people/hurtta/mozi...installer/regus.xpi Status: unknown pop up another window: Mozilla installer <2> with message: Installation has failed due to multiple CRC failures Clicking OK exists installer Expected Results: Installation should habe proceed...
|
||
Updated•23 years ago
|
QA Contact: bugzilla → ktrina
|
Reporter | |
Comment 1•23 years ago
|
||
[hurtta@leija ~/mozilla]$ mozilla-installer/mozilla-installer & [1] 3156 [hurtta@leija ~/mozilla]$ Clicked Next and Accept Changed Destination Directory to /data/mozilla Click Next Set proxy [hurtta@leija ~/mozilla]$ ps -u hurtta -f | grep mozilla hurtta 3156 3037 0 13:03 pts/6 00:00:00 sh mozilla-installer/mozilla-ins hurtta 3158 3156 0 13:03 pts/6 00:00:00 ./mozilla-installer-bin --sync [hurtta@leija ~/mozilla]$ [hurtta@leija ~/mozilla]$ strace -o trace.log -p 3158 Now clicked Install Mozilla installed window opened with message Installation has failed due to multiple CRC failures on terminal window there reads: umovestr: Input/output error trace.log is attached.
|
|
Reporter | |
Comment 2•23 years ago
|
||
select(7, NULL, [6], NULL, {0, 100000}) = 1 (out [6], left {0, 100000})
write(6, "GET ftp://ftp.mozilla.org/pub/mo"..., 154) = 154
open("./xpi/talkback.xpi", O_RDWR|O_CREAT|O_TRUNC, 0666) = 7
select(7, [6], NULL, NULL, {0, 100000}) = 1 (in [6], left {0, 90000})
read(6, "HTTP/1.1 407 Proxy Authenticatio"..., 1024) = 536
select(7, [6], NULL, NULL, {0, 100000}) = 1 (in [6], left {0, 100000})
fstat(7, {st_mode=S_IFREG|0644, st_size=0, ...}) = 0
old_mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) =
0x40018000
select(7, [6], NULL, NULL, {0, 100000}) = 1 (in [6], left {0, 100000})
read(6, "releases/mozilla0.9.5/linux-xpi/"..., 1024) = 245
select(7, [6], NULL, NULL, {0, 100000}) = 1 (in [6], left {0, 100000})
write(7, "<HTML><HEAD><TITLE>407 Proxy Aut"..., 535) = 535
close(7) = 0
Proxy specially do not require any username or password. And I did not antered
any. Is it posisble that installer passes empty username / password to proxy?
That explains why you get
407 Proxy Authenticatio
|
|
Reporter | |
Comment 3•23 years ago
|
||
Yes. Anothher strace is showing that installer sends GET ftp://ftp.mozilla.org/pub/mozilla/releases/mozilla0.9.5/linux-xpi/regus.xpi HTTP/1.1 Host: ftp.mozilla.org:21 Proxy-authorization: Basic Og== In other words installer IS sending empty userdname/password when it should NOT send any. That causes error with proxy. == extrack from strace log: ================================= connect(6, {sin_family=AF_INET, sin_port=htons(8080), sin_addr=inet_addr("128.214.141.2")}}, 16) = 0 select(7, NULL, [6], NULL, {0, 100000}) = 1 (out [6], left {0, 100000}) write(6, "GET ftp://ftp.mozilla.org/pub/mozilla/releases/mozilla0.9.5/linux-xpi/regus.xpi HTTP/1.1\r\nHost: ftp.mozilla.org:21\r\nProx y-authorization: Basic Og==\r\n\r\n", 151) = 151 open("./xpi/regus.xpi", O_RDWR|O_CREAT|O_TRUNC, 0666) = 7 select(7, [6], NULL, NULL, {0, 100000}) = 1 (in [6], left {0, 100000}) read(6, "HTTP/1.1 407 Proxy Authentication Required Now\r\nProxy-Authenticate: Basic realm=\"[ Send response to the following challeng e: 1648681 ]\"\nDate: Wed, 14 Nov 2001 12:20:55 GMT\r\nContent-type: text/html\r\nConnection: Keep-Alive\r\nContent-length: 529\r\n\r \n<HTML><HEAD><TITLE>407 Proxy Authentication Required Now</TITLE></HEAD>\n<BODY>\n<H1>Error: Unable to retrieve the requested URL</H1 ><HR>\n<P>Unable to retrieve the URL: <A HREF=\"ftp://ftp.mozilla.org/pub/mozilla/releases/mozilla0.9.5/linux-xpi/regus.xpi\">ftp://ft p.mozilla.org/pub/mozilla/releases/mozilla0.9.5/linux-xpi/regus.xpi</A><P>\n<P>The following error occured:\n<UL>\n<B>Access Denied. P lease Authenticate with the Proxy. Send response to the following challenge: 1648681</B>\n</UL>\n<HR><I>Created by AltaVista WWW Prox y</I>", 1024) = 775
|
||
Updated•23 years ago
|
QA Contact: ktrina → gbush
|
|
||
Comment 4•23 years ago
|
||
confirming as NEW and adding to cc list
Status: UNCONFIRMED → NEW
Ever confirmed: true
*** This bug has been marked as a duplicate of 84673 ***
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → DUPLICATE
|
|
||
Comment 7•22 years ago
|
||
reopen to mark correct duplicate
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
|
|
||
Comment 8•22 years ago
|
||
*** This bug has been marked as a duplicate of 84763 ***
Status: REOPENED → RESOLVED
Closed: 22 years ago → 22 years ago
Resolution: --- → DUPLICATE
|
||
Comment 10•22 years ago
|
||
Are you sure that this is duplicate of bug 84763 ? 84763 says: | The Proxy log is full of HTTP 500 errors, which means the file could not be | found. | | If you check C:\Windows\Temp\ns_temp, you can see that non of the usual files Failure mode on this bug looks different. I think that these are different bugs.
|
||
Comment 11•22 years ago
|
||
recommend: This bug is not a duplicate, reopen and change summary to reflect root cause, perhaps: "...proxy auth sent even w/o entering username+password..."
|
|
Reporter | |
Comment 12•22 years ago
|
||
This bug is not duplicate of 84763. This bug is about sending of Proxy-agent: -header. Copied http://bugzilla.mozilla.org/show_bug.cgi?id=84763#c31 back to here: ------- Additional Comment #31 From Kari HUrtta 2002-05-22 05:46 ------- (bug 109703 is marked to be duplicate of this) so I say that situation do not have changed. File http://ftp.mozilla.org/pub/mozilla/nightly/latest/mozilla-i686-pc-linux-gnu-installer.tar.gz Date: 22-May-2002 01:28 <...> hurtta@leija mozilla-installer]$ ./mozilla-installer On another window [hurtta@leija ~/mozilla]$ ps -u hurtta -f | grep mozilla-i hurtta 2148 2075 0 15:28 pts/12 00:00:00 sh ./mozilla-installer hurtta 2150 2148 0 15:28 pts/12 00:00:00 ./mozilla-installer-bin hurtta 2233 2182 0 15:30 pts/24 00:00:00 grep mozilla-i [hurtta@leija ~/mozilla]$ strace -o install-11.log -p 2150 Click Next Click Accept Click Change... Select /data/mozilla3 Now Destination Directory is /data/mozilla3/ Click Next Click Proxy Settings... Fill fields Proxy Host Proxy Port Do NOT fill files Proxy Username proxy Password Click OK Click Install Installation fails with Installation has failed due to multiplle CRC failures. CLick OK On install-11.log file there is: connect(6, {sin_family=AF_INET, sin_port=htons(8080), sin_addr=inet_addr("128.214.141.2")}}, 16) = 0 select(7, NULL, [6], NULL, {0, 100000}) = 1 (out [6], left {0, 100000}) write(6, "GET ftp://ftp.mozilla.org/pub/mo"..., 157) = 157 open("./xpi/xpcom.xpi", O_RDWR|O_CREAT|O_TRUNC, 0666) = 7 select(7, [6], NULL, NULL, {0, 100000}) = 1 (in [6], left {0, 90000}) read(6, "HTTP/1.0 407 Proxy Authenticatio"..., 1024) = 536 select(7, [6], NULL, NULL, {0, 100000}) = 1 (in [6], left {0, 100000}) fstat(7, {st_mode=S_IFREG|0644, st_size=0, ...}) = 0 old_mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x40018000 select(7, [6], NULL, NULL, {0, 100000}) = 1 (in [6], left {0, 100000}) read(6, "la/nightly/2002-05-21-21-trunk/l"..., 1024) = 251 select(7, [6], NULL, NULL, {0, 100000}) = 1 (in [6], left {0, 100000}) select(7, [6], NULL, NULL, {0, 100000}) = 1 (in [6], left {0, 100000}) read(6, "", 1024) = 0 write(7, "<HTML><HEAD><TITLE>407 Proxy Aut"..., 541) = 541 close(7) = 0 munmap(0x40018000, 4096) = 0 In other words it still look that installer tries send some authentication information (when it should NOT send any). With another trace <...> hurtta 2297 2295 1 15:40 pts/12 00:00:00 ./mozilla-installer-bin hurtta 2299 2182 0 15:40 pts/24 00:00:00 grep mozilla-i [hurtta@leija ~/mozilla]$ strace -o install-12.log -p 2297 -s 300 install-12.log includes: close(7) = 0 connect(6, {sin_family=AF_INET, sin_port=htons(8080), sin_addr=inet_addr("128.214.141.2")}}, 16) = 0 select(7, NULL, [6], NULL, {0, 100000}) = 1 (out [6], left {0, 100000}) write(6, "GET ftp://ftp.mozilla.org/pub/mozilla/nightly/2002-05-21-21-trunk/linux-xpi/regus.xpi HTTP/1.0\r\nHost: ftp.mozilla.org:21\r\nProxy-authorization: Basic Og==\r\n\r\n" , 157) = 157 open("./xpi/regus.xpi", O_RDWR|O_CREAT|O_TRUNC, 0666) = 7 There is clear that it sends header Proxy-authorization: Basic Og== That causes installation error.
Status: VERIFIED → REOPENED
Resolution: DUPLICATE → ---
Summary: Linux talkback enabled build installer for 0.9.5 fails when using proxy → build installer sends proxy auth even w/o entering username+password
|
|
Reporter | |
Comment 13•22 years ago
|
||
Oops. "is about sending of Proxy-agent: -header." should be "is about sending of Proxy-authorization: -header."
|
Assignee | |
Comment 15•21 years ago
|
||
Reporter: Does the problem exists in newer (1.5) builds? If not then please close the bug as WorksForMe.
|
|
Reporter | |
Comment 16•21 years ago
|
||
Summary: Current proxy do seems not mind about proxy auth, but installer sends it still. ---------------------------------- Current firewall do not require using of proxy and current proxy is different, so that it perhaps do not even complain with sending of empty username and password. But I can try look trace. http://ftp.mozilla.org/pub/mozilla.org/mozilla/releases/mozilla1.6b/mozilla-i686-pc-linux-gnu-installer-1.6b.tar.gz [hurtta@leija ~/moz]$ ls -ltr total 86048 -rw-r--r-- 1 hurtta tih 14117672 Jul 26 2002 jre.xpi -rw-r--r-- 1 hurtta tih 14257409 Nov 7 2002 mozilla-i686-pc-linux-gnu-1.2b-sea.tar.gz -rw------- 1 hurtta tih 14348283 Jan 22 2003 mozilla-i686-pc-linux-gnu-1.3a-sea.tar.gz -rw-r--r-- 1 hurtta tih 40930 Feb 7 2003 crash.2 -rw------- 1 hurtta tih 14531937 Feb 12 2003 mozilla-i686-pc-linux-gnu-1.3b-sea.tar.gz -rw------- 1 hurtta tih 14456411 Mar 26 2003 mozilla-i686-pc-linux-gnu-1.3-sea.tar.gz drwxr-xr-x 3 hurtta tih 4096 Oct 8 06:49 mozilla-installer -rw------- 1 hurtta tih 16120801 Nov 7 12:05 mozilla-i686-pc-linux-gnu-1.5-sea.tar.gz -rw------- 1 hurtta tih 101963 Dec 18 09:39 mozilla-i686-pc-linux-gnu-installer-1.6b.tar.gz [hurtta@leija ~/moz]$ rm -rf mozilla-installer [hurtta@leija ~/moz]$ tar xzf mozilla-i686-pc-linux-gnu-installer-1.6b.tar.gz [hurtta@leija ~/moz]$ cd mozilla-installer/ [hurtta@leija mozilla-installer]$ [hurtta@leija mozilla-installer]$ ./mozilla-installer another window [hurtta@leija ~]$ ps -u hurtta -f | grep mozilla-i hurtta 20924 20680 0 09:44 pts/1 00:00:00 /bin/sh ./mozilla-installer hurtta 20926 20924 0 09:44 pts/1 00:00:00 ./mozilla-installer-bin hurtta 20981 20938 0 09:44 pts/3 00:00:00 grep mozilla-i [hurtta@leija ~]$ [hurtta@leija ~]$ strace -o mozilla-test.log -p 20926 Click Next Click Accept Click Change Select /home/hurtta/mozilla-test Click Next Click Yes when installer asks that should /home/hurtta/mozilla-test created. Click Proxy Settings Fill Proxy Host Proxy Port Click OK Click Install Install seems start downloading ok (except that it comes slowly -- only 11 KB/sec) mozilla-test.log seems quite ok: write(6, "GET http://ftp.mozilla.org/pub/m"..., 163) = 163 open("./xpi/xpcom.xpi", O_RDWR|O_CREAT|O_TRUNC, 0666) = 7 select(7, [6], NULL, NULL, {0, 100000}) = 0 (Timeout) select(7, [6], NULL, NULL, {0, 100000}) = 0 (Timeout) select(7, [6], NULL, NULL, {0, 100000}) = 0 (Timeout) select(7, [6], NULL, NULL, {0, 100000}) = 0 (Timeout) select(7, [6], NULL, NULL, {0, 100000}) = 0 (Timeout) select(7, [6], NULL, NULL, {0, 100000}) = 1 (in [6], left {0, 10000}) read(6, "HTTP/1.0 200 OK\r\nDate: Thu, 18 D"..., 1024) = 327 select(7, [6], NULL, NULL, {0, 100000}) = 1 (in [6], left {0, 80000}) select(7, [6], NULL, NULL, {0, 100000}) = 1 (in [6], left {0, 100000}) read(6, "PK\3\4\n\0\0\0\0\0Np\212/\0\0\0\0\0\0\0\0\0\0\0\0\4\0\25"..., 1024) = 1024 select(7, [6], NULL, NULL, {0, 100000}) = 1 (in [6], left {0, 100000}) fstat64(7, {st_mode=S_IFREG|0644, st_size=0, ...}) = 0 old_mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x4046d000 select(7, [6], NULL, NULL, {0, 100000}) = 1 (in [6], left {0, 100000}) read(6, "N\2\334/\365\222H\17A\275\247\221~\n\374\fi\333L\274h|"..., 1024) = 424 select(7, [6], NULL, NULL, {0, 100000}) = 0 (Timeout) select(7, [6], NULL, NULL, {0, 100000}) = 1 (in [6], left {0, 20000}) read(6, "$\275\242\207\372+\1\27H\376\331\274\262\253\1\335=\264"..., 1024) = 1024 But that trace have to short logs .. tried another install (pressing Cancel to install ) Next Accept Change Proxy Settings ... on another window [hurtta@leija ~]$ ps -u hurtta -f | grep mozilla-i hurtta 21160 20680 0 09:54 pts/1 00:00:00 /bin/sh ./mozilla-installer hurtta 21162 21160 0 09:54 pts/1 00:00:00 ./mozilla-installer-bin [hurtta@leija ~]$ [hurtta@leija ~]$ strace -o mozilla-test2.log -p 21162 -s 400 Install Install seeems start downloading OK... mozilla-test2.log shows: write(6, "GET http://ftp.mozilla.org/pub/mozilla.org/mozilla/releases/mozilla1.6b/linux-xpi/xpcom.xpi HTTP/1.0\r\nHost: ftp.mozilla.org:80\r\nProxy-authorization: Basic Og==\r\n\r\n", 163) = 163 open("./xpi/xpcom.xpi", O_RDWR|O_CREAT|O_TRUNC, 0666) = 7 select(7, [6], NULL, NULL, {0, 100000}) = 1 (in [6], left {0, 100000}) read(6, "HTTP/1.0 200 OK\r\nDate: Thu, 18 Dec 2003 07:49:28 GMT\r\nServer: Apache/2.0.47\r\nLast-Modified: Wed, 10 Dec 2003 22:43:05 GMT\r\nETag: \"34c15e-d92dc-3a09040\"\r\nAccept-Ranges: bytes\r\nContent-Length: 889564\r\nContent-Type: application/x-xpinstall\r\nX-Pad: avoid browser bug\r\nAge: 487\r\nX-Cache: HIT from wwwcache.fmi.fi\r\nProxy-Connection: close\r\n\r\nPK\3\4\n\0\0\0\0\0Np\212/\0\0\0\0\0\0\0\0\0\0\0\0\4\0\25\0bin/UT\t\0\3\364\227\327?\364\227\327?Ux\4\0\364\1\n\0PK\3\4\24\0\0\0\10"..., 1024) = 1024 There still seems to have Proxy-authorization: Basic Og== header. It is just that current proxy do not mind about it. ------------------------------------- So I think that bug mentioned on subjetc is not fixed (althougg it doe snot cause problems because of different environment.) / Kari H.
|
|
||
Comment 17•21 years ago
|
||
-> defaults. We need to get this fixed now that people can pay to get support for mozilla, they will expect this to work.
Assignee: syd → general
Status: REOPENED → NEW
QA Contact: agracebush → bugzilla
|
|
Assignee | |
Updated•21 years ago
|
Assignee: general → opi
|
|
Assignee | |
Comment 18•21 years ago
|
||
A patched installer can be downloaded from http://www.opiswelt.de/mozilla/mozilla-installer-bin ... please overwrite your installer file with this one and try if it works (I've no proxy around me so I can't test it self).
|
|
Assignee | |
Updated•21 years ago
|
Status: NEW → ASSIGNED
|
||
Comment 19•21 years ago
|
||
Comment on attachment 137749 [details] [diff] [review] Give NULL to SetProxyInfo if no password AND no user is given (instead of a clear string) I can't get to this until Jan 7-8 at the earliest; I don't know the code very well. dveditz may be able to review sooner, he's around these days.
Attachment #137749 -
Flags: review?(bsmedberg)
|
|
||
Comment 20•21 years ago
|
||
Comment on attachment 137749 [details] [diff] [review] Give NULL to SetProxyInfo if no password AND no user is given (instead of a clear string) >+ if ((*gCtx->opt->mProxyUser == '\0') && >+ (*gCtx->opt->mProxyPswd == '\0')) >+ { >+ conn->SetProxyInfo(qualURL, NULL, NULL); >+ } else >+ { >+ conn->SetProxyInfo(qualURL, gCtx->opt->mProxyUser, >+ gCtx->opt->mProxyPswd); >+ } I saw another bug about this recently, I forget which; you were supposed to send a username to the proxy, but not a password, or vice-versa. In any case, this code can be simplified: char* user = nsnull, pswd = nsnull; if (*gCtx->opt->mProxyUser) { user = gCtx->opt->mProxyUser; } if (*gCtx->opt->mProxyPswd) { user = gCtx->opt->mProxyPswd; } conn->SetProxyInfo(qualURL, user, pswd); Or even use a ?: construct, although that might be pusing the limits of readability.
Attachment #137749 -
Flags: review?(bsmedberg) → review-
|
|
Assignee | |
Comment 21•21 years ago
|
||
@bsmedberg I think my code is better then the one you suggest. 1.) It needs no extra memory (ok, its the installer). 2.) in your if condition ... *gCtx->opt->mProxyUser and *gCtx->opt->mProxyPassword are every time true. 3.) If you mean that we set user to null if we have no text for *gCtx->opt->mProxyUser or to set password to null if we have no *gCtx->opt->mProxyPassword then we have for given Username "foo" with no given Password conn->SetProxyInfo(qualURL, "foo", NULL); But now it won't work any more cause of http://lxr.mozilla.org/seamonkey/source/xpinstall/wizard/libxpnet/src/nsHTTPConn.cpp#305 and that's not what we want. (And I know no case of a proxy software that want an user name and no password, or a password and no username ... all want a clear string on that position ... and I don't know a way for such things cause the http/ftp proxy request is "username:password") Also it follows the code of the windows installer version (But there should be a problem with a setting like "username foo with no given password" and I haven't found a bug for this but someone should change the lines in question).
|
|
||
Comment 22•21 years ago
|
||
Comment on attachment 137749 [details] [diff] [review] Give NULL to SetProxyInfo if no password AND no user is given (instead of a clear string) (*gCtx->opt->mProxyUser) is *not* always true, it is the exact opposite of your *gCtx->opt->mProxyUser == '\0' In any case, I'm now convinced I am incompetent to review this. Asking darin.
Attachment #137749 -
Flags: review- → review?(darin)
|
|
Reporter | |
Comment 23•21 years ago
|
||
To comment 18: sorry, I can not test http://www.opiswelt.de/mozilla/mozilla-installer-bin ========================================= [hurtta@leija ~/moz]$ wget http://www.opiswelt.de/mozilla/mozilla-installer-bin --09:41:29-- http://www.opiswelt.de/mozilla/mozilla-installer-bin => `mozilla-installer-bin' Resolving wwwproxy.fmi.fi... done. Connecting to wwwproxy.fmi.fi[193.166.223.5]:8080... connected. Proxy request sent, awaiting response... 200 OK Length: 178,644 [text/plain] 100%[=========================================================>] 178,644 69.89K/s ETA 00:00 09:41:32 (69.89 KB/s) - `mozilla-installer-bin' saved [178644/178644] [hurtta@leija ~/moz]$ [hurtta@leija ~/moz]$ cd mozilla-installer [hurtta@leija mozilla-installer]$ ls config.ini installer.ini mozilla-installer mozilla-installer-bin MPL-1.1.txt README xpi [hurtta@leija mozilla-installer]$ mv mozilla-installer-bin mozilla-installer-bin.OLD [hurtta@leija mozilla-installer]$ cp ../mozilla-installer-bin . [hurtta@leija mozilla-installer]$ [hurtta@leija mozilla-installer]$ ./mozilla-installer ./mozilla-installer: ./mozilla-installer-bin: Permission denied [hurtta@leija mozilla-installer]$ chmod a+rx mozilla-installer [hurtta@leija mozilla-installer]$ ./mozilla-installer ./mozilla-installer: ./mozilla-installer-bin: Permission denied [hurtta@leija mozilla-installer]$ chmod a+rx mozilla-installer-bin [hurtta@leija mozilla-installer]$ ./mozilla-installer ./mozilla-installer-bin: error while loading shared libraries: libstdc++.so.5: cannot open shared object file: No such file or directory [hurtta@leija mozilla-installer]$
|
|
Assignee | |
Comment 24•21 years ago
|
||
@bsmedberg I mean "if (*gCtx->opt->mProxyUser)" is every time true in our context, cause "*gCtx->opt->mProxyUser" shouldn't be NULL on this position (it have the String from the UI and this isn't NULL). And I thought that "if (*gCtx->opt->mProxyUser)" returns TRUE if "*gCtx->opt->mProxyUser=='\0'; (Maybe I'm wrong on this.) But if it is so, this doesn't make Point 3 of comment #21 more happy. @Kari HUrtta My compile system is a debian unstable so it needs the most very last existing libraries. I can't build for lower system's yet.
|
|
Assignee | |
Comment 25•21 years ago
|
||
Ok, after Kari have bring my Brain back from Java to C/C++ I'm for following patch:
>+ if ((*gCtx->opt->mProxyUser) || (*gCtx->opt->mProxyPswd))
>+ {
>+ conn->SetProxyInfo(qualURL, gCtx->opt->mProxyUser,
>+ gCtx->opt->mProxyPswd);
>+ } else
>+ {
>+ conn->SetProxyInfo(qualURL, NULL, NULL);
>+ }
|
||
Comment 26•21 years ago
|
||
Comment on attachment 137749 [details] [diff] [review] Give NULL to SetProxyInfo if no password AND no user is given (instead of a clear string) r=darin
Attachment #137749 -
Flags: review?(darin) → review+
|
|
||
Comment 27•21 years ago
|
||
checked in on trunk
Status: ASSIGNED → RESOLVED
Closed: 22 years ago → 21 years ago
Resolution: --- → FIXED
Target Milestone: mozilla1.0 → mozilla1.7alpha
|
|
||
Comment 28•20 years ago
|
||
V/fixed: Mozilla 1.7RC1branch, 20040504 I've used snoop to verify this on my Solaris proxy.
Status: RESOLVED → VERIFIED
Keywords: nsbeta1-
QA Contact: bugzilla → benc
Summary: build installer sends proxy auth even w/o entering username+password → Proxy: installer sends auth even w/o entering username+password
|
||
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•