109808 - * style overrides textarea style

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[Paul Baker]

When using a style sheet that contains a default * rule and also a textarea
rule, the * rule is used for textarea elements instead of the better matching
textarea rule.

Steps to reproduce:
1. create a style sheet with a * and differing textarea rule.
2. link to this stylesheet in an html document.
3. include a form that has a <textarea></textarea> form element.

Actual results:
The text contents of the <textarea> box will be styled using the * rule.

Expected results:
The text contents of the <textarea> box will be styled using the textarea rule.

Additional information:
This problem does not exist in Mozilla 0.9.5 (2001101117). It does not exist in
Mozilla Build 2001110503 on at least Windows 2000. It does not exist in Internet
Explorer 5.50.4807.2300. It does not exist in Konqueror 2.1.1.

This problem started appearing in Mozilla Build 2001110603. It still exists in
build 2001111203.

I will attach a test case.

Also, I consider this to be a blocker for 0.9.6 because if 0.9.6 releases with
this problem, it will be unusable to me and I will have to continue using 0.9.5.

Comment 1

[Paul Baker]

Attachment: test.css - stylesheet containing * and textarea rules.

save this as test.css

Comment 2

[Paul Baker]

Attachment: bug_in_stylesheets.html - html file that links to test.css exhibiting the bug

save as bug_in_stylesheets.html in the same directory as test.css.

Comment 3

[basic]

Attachment: testcase (that links to stylesheet attachment)

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: stylesheet for more specific testcase

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: more specific testcase

Comment 6

[Boris Zbarsky [:bzbarsky]]

It looks like both "textarea > div" and "*" will match the anonymous div in the
textarea.  This is not good... :)

But it's also not a blocker. Downgrading to major (please read the severity
descriptions).

Comment 7

[Paul Baker]

read them now, my bad. thought blocker meant it blocked a release. :-/

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This is because textareas contain an "anonymous" DIV internally that can be
styled by the style rules in the page.  XBL form controls would solve this since
we'd have the option of cutting off style.  For now, that's a bit difficult,
although it could be done.  Reassigning to HTML Form Controls.

Comment 9

[Paul Baker]

It disappoints me that the target release for fixing this bug has been pushed
back to 0.9.7 considering that it does not exist in 0.9.5. I suppose that's what
I get for waiting 5 days to report it. I guess I'll just have to hope it some
how makes it into 0.9.6.

The problem still exists of course in the 2001111411 0.9.6 build.

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Checkins during that time period were:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=MozillaTinderboxAll&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2001-11-05+00%3A00&maxdate=2001-11-06+08%3A00&cvsroot=%2Fcvsroot

Could fantasai's changes have caused this?

What prevented it from happening in the past, anyway?

Comment 11

[fantasai]

> Could fantasai's changes have caused this?

Apparently so--I built 11-04 and then built again with 43220's patch. The 
<textarea>'s text is sans-serif with the patch.

Comment 12

[Paul Baker]

Problem still exists in 0.9.6 (build 2001112009) on Windows 2000. :~( I'll have
to stick with 0.9.5 until this gets fixed in a nightly.

Comment 13

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

*** Bug 111239 has been marked as a duplicate of this bug. ***

Comment 14

[fantasai]

'Twas a copy error. I should've checked that more carefully..

nsStyleSet.cpp - in StyleSetImpl::FileRules - 
- if (mDocRuleProcessors) {
+ if (mDocRuleProcessors && useRuleProcessors) { 

Reassigning to Style System.
Do you need a formal patch?

Comment 15

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

r=dbaron

Comment 16

[fantasai]

[e-mail] wrote:  sr=hyatt

dbaron, will you check in the fix?

Comment 17

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

*** Bug 112148 has been marked as a duplicate of this bug. ***

Comment 18

[Jacob Kjome]

Is this also what is causing the weird scrollbar styling behavior in bug 109087?

Here is the URL of the page that is looks weird in Mozilla (hint: try making
mozilla horizontally thinner and look at the bottom scrollbar):
http://bugzilla.mozilla.org/attachment.cgi?id=18503&action=view

Here is an image of what I see:
http://bugzilla.mozilla.org/attachment.cgi?id=57098&action=view

The offending style seems to be:
* { border: solid 1px blue; margin: 4px; padding: 4px; }

Maybe bug 109087 is a dup of this?

Jake

Comment 19

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Fix checked in 2001-11-27 20:54 PDT.  Thanks for the patch, fantasai.

Comment 20

[Jacob Kjome]

I guess I'll answer my own question.  Yes!  The fix for this does fix the weird 
scrollbar behavior that I saw.  Also, that bug was about part of the page not 
displaying, originally.  However, I've been able to see all text on the page 
for quite a while.  So, I don't think bug 109087 is a dup, but it may be a WFM 
now.

Jake

Comment 21

[Boris Zbarsky [:bzbarsky]]

*** Bug 113437 has been marked as a duplicate of this bug. ***

Comment 22

[fantasai]

> Thanks for the patch, fantasai.

You're welcome, of course. I owed it to you.

BTW, if the 0.9.6 branch is still being used for anything significant, you might 
want to change it there, too. The missing check seems to be causing problems for 
people; we've had several duplicates and a newsgroup post in a short amount of 
time.

Comment 23

[Boris Zbarsky [:bzbarsky]]

*** Bug 114193 has been marked as a duplicate of this bug. ***

Comment 24

[Madhur Bhatia]

verified