1102496 - Keypad delete button is pointed the wrong way and padded incorrectly

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[Doug Sherk (:drs) (inactive)]

Attachment: Screenshot

In RTL mode, the keypad delete button is too far to the left, and is pointing the wrong way.

Comment 1

[Doug Sherk (:drs) (inactive)]

Attachment: Proposed visual design after fix

Ahmed, here is my proposal for how this will look after being fixed. Does this look correct to you, other than minor imperfections in pixels of padding?

Comment 2

[Ahmed Nefzaoui [:Nefzaoui]]

Well, I think the best way to do this is what's proposed in Bug 1011731, Forcing the whole Dialer keypad view to be rendered LTR even with RTL languages. That is because the direction people write numbers with in RTL languages is the same of non-RTLs (i.e English, French...), all from left towards right.
Competitors does that too :) Which actually makes sense.. :)

Comment 3

[Doug Sherk (:drs) (inactive)]

This might end up not being any work based on comment 2, but I need to talk with Stephany about this.

Comment 4

[Doug Sherk (:drs) (inactive)]

Attachment: Force render the keypad delete button in LTR, even in RTL mode.

PR: https://github.com/mozilla-b2g/gaia/pull/26565

Needinfo on myself for rebase and demo.

Comment 5

[Doug Sherk (:drs) (inactive)]

Bug 1011731 partially fixed this, but not entirely.

Comment 6

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8530465 [details] [diff] [review]
Force render the keypad delete button in LTR, even in RTL mode.

Good to see that this one ended up being a one-liner :)

Comment 7

[Doug Sherk (:drs) (inactive)]

Master: https://github.com/mozilla-b2g/gaia/commit/65e97a2624638c726cce27f0b7af81952a5f312b

Comment 8

[Elie]

Accordding to  Comment 2 
Forcing the whole Dialer keypad view to be rendered LTR even with RTL languages
This issue verified successfully on Flame 2.2
Gaia-Rev        f5b3d1b6cfa3e702033f613915ae637cb735cbfb
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/8067c111ddff
Build-ID        20150118002501
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
Refer to video

Comment 9

[Elie]

Attachment: VIDEO0255.mp4

Comment 10

[Alissa（leave from Mozilla）]

Test case has been added in moztrap:

https://moztrap.mozilla.org/manage/case/15421/