110369 - Lines through images when embedded in tables

Status: VERIFIED FIXED

(Core :: Layout, defect, P3)

Description

[jhp (no longer active)]

Sometimes, lines will appear in images when scrolling.  This happens 
if the image is center vertically aligned in a table, the image height 
is smaller than the table cell height, and the difference between the 
cell height and image height is odd.  When finding out how to 
vertically align, the code divides the difference by 2.  If the 
difference is odd, this results in a half-pixel value, which leads to 
the lines through images when redrawing parts of the image.

Comment 1

[jhp (no longer active)]

Attachment: patch

Comment 2

[Jeremy M. Dolan]

I see lines on the images when I scroll at:
http://homepage.mac.com/simonster/PhotoAlbum3.html

Not sure if it's the same thing since this bug doesn't have a URL/testcase, but
hopefully this fixes that page too.

Also noticed a similar problem of text unaligning in the middle during scroll.
The top half of the letters were being shifted 1-2 pixels left.

Comment 3

[Mike Kaply [:mkaply]]

Jeremy,

What platform are you running on?

Comment 4

[Jeremy M. Dolan]

Oct. 26th Linux build. Plan to try a 0.9.6 branch build tomarrow, now that
search is finally fixed. I'll see if I still experiance it there.

Comment 5

[karnaze (gone)]

Attachment: revised patch to round down (the way Javier originally had it)

Comment 6

[Bernd]

shouldn't we fix
http://lxr.mozilla.org/seamonkey/source/layout/html/table/src/nsTableOuterFrame.cpp#507
also, which shows the same pattern?

Comment 7

[karnaze (gone)]

Bernd, I'm planning to open a new bug if there are case where MoveTo, SizeTo, 
SetRect are not rounding. But I want to get this in right now. Actually, I 
think the case you cite would not need to be fixed if the other frames were ok.

Comment 8

[karnaze (gone)]

The patch is in. Scratch the last part of my last comment. The new bug is bug 
110474.

Comment 9

[Jeremy M. Dolan]

I don't see the lines anymore on the URL I posted. Linux 2001111506, which is
before the patch was checked in. May have been a seperate issue.

Comment 10

[jhp (no longer active)]

verified