111101 - No scrollbox / slider / thumb in thread pane scrollbar

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P1)

Description

[Stephen Compall]

I loaded up n.p.m.general, only to find that there was no scrollbox! The arrows
were still there, and clicking in the empty space still produced paging, but no
scroll _bar_!

Comment 1

[Stephen Compall]

Attachment: the scrollbar on my message list

Comment 2

[Stephen Compall]

WORKAROUND:
First, pick a mail folder that causes a scrollbar to appear. Wala! the bug is
gone. But if you close mail and restart...

Comment 3

[Olga]

I saw this when moved from one folder to another.

Comment 4

[Olga]

*** Bug 112492 has been marked as a duplicate of this bug. ***

Comment 5

[(not reading, please use [e-mail] instead)]

accepting.  marking all, I see this on win2k as well.

Comment 6

[Olga]

*** Bug 112691 has been marked as a duplicate of this bug. ***

Comment 7

[jay garcia]

I searched for a bug before I entered mine. You call it a "scrollbox". No wonder
why !! :-)

Comment 8

[laurel]

*** Bug 112733 has been marked as a duplicate of this bug. ***

Comment 9

[(not reading, please use [e-mail] instead)]

I'm having problems reproducing this, but I have seen it.

bienvenu suggestions doing this, to reproduce it:

"after starting up, I selected a folder with less than a threadpane full of 
messages, (e.g, 4).  deleted the last message.  then open a large folder.  the 
large folder didn't have the scroll bar."

olga / laurel, are you able to reproduce this?  

Comment 10

[Olga]

Good steps! I could reproduce on today's build only in this way. I deleted a
message from a short folder, then went to my Inbox. No scroll box.

Comment 11

[R.K.Aa.]

*** Bug 112994 has been marked as a duplicate of this bug. ***

Comment 12

[R.K.Aa.]

*** Bug 113680 has been marked as a duplicate of this bug. ***

Comment 13

[R.K.Aa.]

I'm unable to reproduce this bug.
Does deleting .mozilla/<profile>/<salt> /XUL.mfasl before starting mozilla cure
it? (XUL.mfl on Windows)

Comment 14

[Aleksander Adamowski]

My duplicate of this bug was because I couldn't find a bug for MailNews with the
substring "scrollbar" in the summary... I'm appending "scrollar" word to the
summary...

Comment 15

[Jan Varga [:janv]]

I can't reproduce it with current build on linux.
I've seen it too.

Comment 16

[Kevin McCluskey (gone)]

I see this bug on my mail inbox with recent builds on WINXP and WINNT. The thumb
disappears and does not reappear unless I click on another mail folder.

Comment 17

[[not reading bugmail]]

R.K.A.

I tried that and it didn't work.  I see this on dialup, with Modern it doesn't
display the thread (pick any from mozilla news) the scrollbar shows allocated
verticle space, then when the messages load up scrollbar and scrollbox appear. 
Classic theme doesn't do this.. but doesn't have scrollbox at all.  (so
possibly) maybe someone did some cleaning of themes and missed this?

Comment 18

[[not reading bugmail]]

Try from dead cold Mozilla, open Mail/News;

thread pane is the only item I can see is affected by this problem.

this is on first load.. expand news.mozilla.org.. let it update the newsgroup
subscription #'s.  Then select any newsgroup (I have only downloaded 100 headers
total - after using account wizard on a previous new profile creation) this
shows up as I stated above.  Classic is missing slider (it shows arrow buttons),
modern doesn't do that, but It allocated some visual space for the scrollbar
(w/slider & arrows) but doesn't actually fill that in till the threads are
loaded.  So after threads are loaded, Modern seems fine to me. 

Comment 19

[jay garcia]

Missing here on Classic as well as Modern.

Comment 20

[[not reading bugmail]]

I just trying this on the 12-10-03 w2k build, and it doesn't have any problems I
can see right now.  It appears to me like it works fine on Classic.

Comment 21

[scottputterman]

I also tried the 12/10 build on Win 2000 and I could reproduce it by going into
a folder with a scrollbar. Deleting enough messages to make the scrollbar
disappear. Then switch to a folder that should have a scrollbar.  The scrollbar
appears but there's no thumb.

That said, this used to happen to me all of the time and now I had to force it
to happen.

Comment 22

[Jan Varga [:janv]]

Hmm, this is really strange. Is anyone able to reproduce this bug with a clean
new profile ?

Comment 23

[Olga]

*** Bug 115084 has been marked as a duplicate of this bug. ***

Comment 24

[(not reading, please use [e-mail] instead)]

I got into this state, so I fired up the document inspector.

check out the screen shot.

Comment 25

[(not reading, please use [e-mail] instead)]

Attachment: screen shot

in this screen shot, notice what got highlighted in red when I selected the
scroll bar thumb.

it's got no height.

Comment 26

[(not reading, please use [e-mail] instead)]

if I switch folders, and come back, and the select the thumb, it shows a "full" 
red box.

any ideas?

Comment 27

[Jan Varga [:janv]]

While I've been trying to track this bug, I noticed that we're setting
negative max positon in InvalidateScrollbar(). It doesn't have to be
a problem, but I'll try to fix it and then reproduce it again.

Last I was able to reproduce it I clicked on a not empty folder, thread pane 
didn't display any message headers and then I got into the state of no thumb
in thread pane scrollbar.

Comment 28

[[not reading bugmail]]

I seen this after importing my bookmarks file (using classic theme) from the
12-12 build into 12-13 build.  Scollbar's slider is missing.  It was the first
time I used manage bookmarks.. and I had not used mail/news yet.  So it happens
in more that one place.

Comment 29

[[not reading bugmail]]

Seth, I'm thinking this here that is the cause of this problem.. 

http://bugzilla.mozilla.org/show_bug.cgi?id=113528#c3

Comment 30

[[not reading bugmail]]

I just saw the same behavior in classic theme again in mail/news after expanding
it but didn't click on any newsgroup.. then it disappeared to no rectangle is
visable .. the scrollbar had a visible rectangle when clicking on expand
news.mozilla.org..

I hope this stuff helps.

Comment 31

[Alec Flett]

I think that this bites me sometimes after I use the quicksearch feature.. I'm
not 100% that's what's causing it though.

Comment 32

[scottputterman]

I can do it easily without Quick Search, but Quick Search would make sense given
the way I'm seeing it.  If I go to a folder without a scrollbar and delete a
message and change to a folder with a scrollbar, I often see no thumb.  I was
just able to reproduce it on the 12/14 build.  I went to a folder with one
message.  I deleted that message.  I switched to my 3500 message Inbox and got a
scrollbar, but no thumb.

Comment 33

[[not reading bugmail]]

looks like some scrollbar checkins in the tree today, as well as for a few days
past.

Comment 34

[(not reading, please use [e-mail] instead)]

quick search is showing something interesting.

if I select my inbox, and quick search, the scroll bar thumb doesn't always change.

specifically, if I go from no search or a search with hits, to a search with no
hits.

I'll work on that issue, as it is a bug, and continue to investigate this beast.

Comment 35

[[not reading bugmail]]

possibly related: Has this occured after landing the thread-outliner?  And maybe
since other stuff like the manage bookmarks is also using outliner.. any chances
this is a side effect of the outliner code in general?

Comment 36

[Jan Varga [:janv]]

taking

Comment 37

[Jan Varga [:janv]]

Seems like hyatt just checked in a fix for this.

Comment 38

[(not reading, please use [e-mail] instead)]

testing hyatt's fix now, to see if it helps.

Comment 39

[Jan Varga [:janv]]

it's better, there is thumb now, but thumb is smaller as should be

Comment 40

[(not reading, please use [e-mail] instead)]

after hyatt's patch, I still see the problem when I do a quick search on my 
inbox with "xxxxxxxxx" (which there are no hits.)

this might be another bug, but I'll continue on with it here.

for me, the problem is that the scrollbar is not being collapsed, which is why 
we still see it.

Comment 41

[(not reading, please use [e-mail] instead)]

here's part of the quick search problem.  on search, we clear the outliner.

from nsMsgThreadedDBView::OnNewSearch()
  
if (mOutliner)
  {
    PRInt32 viewSize = m_keys.GetSize();
    mOutliner->RowCountChanged(0, -viewSize); // all rows gone.
  }


in RowCountChanged(), we Invalidate the scroll bar, but we never set it as 
invisible

when we call SetVisibleScrollbar((rowCount >= mPageCount));

rowCount is the old size and mPageCount is the old page count, (for my inbox 
test, 298 >= 12, so we set the scrollbar to be visible.  


    
NS_IMETHODIMP nsOutlinerBodyFrame::RowCountChanged(PRInt32 aIndex, PRInt32 
aCount)
{
  if (aCount == 0 || !mView)
    return NS_OK; // Nothing to do.

  PRInt32 count = aCount > 0 ? aCount : -aCount;
  PRInt32 rowCount;
  mView->GetRowCount(&rowCount);

  // Adjust our selection.
  nsCOMPtr<nsIOutlinerSelection> sel;
  mView->GetSelection(getter_AddRefs(sel));
  if (sel)
    sel->AdjustSelection(aIndex, aCount);

  PRInt32 last;
  GetLastVisibleRow(&last);
  if (aIndex >= mTopRowIndex && aIndex <= last)
    InvalidateRange(aIndex, last);

  if (mTopRowIndex == 0) {    
    // Just update the scrollbar and return.
    InvalidateScrollbar();
    SetVisibleScrollbar((rowCount >= mPageCount));
    return NS_OK;
  }

Comment 42

[(not reading, please use [e-mail] instead)]

testing this fix:

-    SetVisibleScrollbar((rowCount >= mPageCount));
+    SetVisibleScrollbar((rowCount + aCount >= mPageCount));

Comment 43

[(not reading, please use [e-mail] instead)]

Attachment: fix for the "quick search" problem.

Comment 44

[(not reading, please use [e-mail] instead)]

explanation of the fix:

when the row count changes, and we're at the top (mTopRowIndex == 0),
the scroll bar visibility depends on the adjusted row count, not the previous 
row count.

Comment 45

[(not reading, please use [e-mail] instead)]

I'm narrowing in on the problem of when you go back from quick search to inbox, 
and the scrollbar thumb is gone, working on that now.

I think the problem is that when we restore the view, (see 
nsMsgThreadedDBView::ReloadFolderAfterQuickSearch()) we need to invalidate the 
outliner, possibly the outliner as well, but I'm not sure about that.

testing a patch now.

Comment 46

[(not reading, please use [e-mail] instead)]

taking back, I don't think this is a hyatt problem.

here comes the patch to outliner and the db view code...

Comment 47

[(not reading, please use [e-mail] instead)]

Attachment: patch, please review

patch for both going into quick search, and coming out of it.

Comment 48

[(not reading, please use [e-mail] instead)]

discussed this with bienvenu over aim, and he suggests this:

RowCountChange(0,m_keys.GetSize() * -1);
RemoveAll()
m_keys.Insert();
Sort();
RowCountChange(0,m_keys.GetSize());

testing that out now.

Comment 49

[(not reading, please use [e-mail] instead)]

Attachment: patch, v2.

Comment 50

[David :Bienvenu]

Comment on attachment 62261 [details] [diff] [review]
patch, v2.

sr=bienvenu

Comment 51

[Navin Gupta]

Comment on attachment 62261 [details] [diff] [review]
patch, v2.

r=naving for the 
db view part.

Comment 52

[(not reading, please use [e-mail] instead)]

Attachment: updated patch, same mailnews patch, updated patch to layout

Comment 53

[(not reading, please use [e-mail] instead)]

jan, that last patch has problems, so I'm going back to my original patch.

the last patch causes the scrollbar to be invisible when it shouldn't, I'll 
look at the code and see why.

Comment 54

[[e-mail] (gone - use [e-mail] instead)]

Is bug 111321 relate/dup?

Comment 55

[(not reading, please use [e-mail] instead)]

I've checked in the mailnews part of this fix into the trunk, I still need to 
figure out if my fix for layout is correct.

Comment 56

[(not reading, please use [e-mail] instead)]

I'll finish up the layout part for 0.9.8

0.9.7 is out the door.

Comment 57

[(not reading, please use [e-mail] instead)]

over to jan, he's got the rest of this fix in his local tree and will be 
checking in along with his fix for #116855

currently, we call RowCountChange() with -count before we do remove all, in his 
patch we do it afterwards.

the problem is rowcountchanged was called before it was really changed
and rowcountchanged calls getrowCount().

thanks for fixing this jan.

Comment 58

[Jan Varga [:janv]]

fixed

Comment 59

[Jan Varga [:janv]]

Can someone verify that this is really fixed ?
I don't see it anymore, just for sure.

Comment 60

[Olga]

Verified on today's and yesterday build 2002-01-03.
Win 2K, Linux, Mac OSX.

Comment 61

[Håkan Waara]

*** Bug 119278 has been marked as a duplicate of this bug. ***

Comment 62

[Håkan Waara]

*** Bug 119156 has been marked as a duplicate of this bug. ***

Comment 63

[Aleksey Nogin]

*** Bug 120126 has been marked as a duplicate of this bug. ***

Comment 64

[Matthias Versen [:Matti]]

*** Bug 120180 has been marked as a duplicate of this bug. ***

Comment 65

[Tuukka Tolvanen (sp3000)]

*** Bug 120476 has been marked as a duplicate of this bug. ***

Comment 66

[Matthias Versen [:Matti]]

*** Bug 120752 has been marked as a duplicate of this bug. ***

Comment 67

[Olga]

*** Bug 120477 has been marked as a duplicate of this bug. ***