Closed
Bug 111346
Opened 23 years ago
Closed 21 years ago
remove content quality stubs
Categories
(Core :: DOM: HTML Parser, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla1.5beta
People
(Reporter: dbaron, Assigned: dbaron)
References
Details
(Whiteboard: [patch])
Attachments
(1 file)
42.70 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
We should remove the content quality stubs -- we don't have a parser that's capable of producing any accurate indication of content quality. Even if we did, setting it in the view manager / pres shell doesn't make much sense. Search LXR for nsContentQuality, aQualityLevel, SetQuality, etc.
Assignee | ||
Updated•23 years ago
|
Status: NEW → ASSIGNED
Priority: -- → P3
Target Milestone: --- → Future
*** Bug 120904 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 2•21 years ago
|
||
Assignee | ||
Updated•21 years ago
|
Whiteboard: [patch]
Target Milestone: Future → mozilla1.5beta
Assignee | ||
Updated•21 years ago
|
Attachment #128031 -
Flags: superreview?(bzbarsky)
Attachment #128031 -
Flags: review?(bzbarsky)
Comment 3•21 years ago
|
||
Comment on attachment 128031 [details] [diff] [review] patch r+sr=me. This was hacked into _views_?? I sort of wonder how much of the CRC stuff in the parser we can also remove....
Attachment #128031 -
Flags: superreview?(bzbarsky)
Attachment #128031 -
Flags: superreview+
Attachment #128031 -
Flags: review?(bzbarsky)
Attachment #128031 -
Flags: review+
Assignee | ||
Comment 4•21 years ago
|
||
Fix checked in to trunk, 2003-07-22 11:38 -0700.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Just updated my tree and noted that this broke debug builds. viewer still has a dangling reference: http://lxr.mozilla.org/mozilla/search?string=GetShowQuality
mozilla/webshell/tests/viewer/nsBrowserWindow.cpp still broken for me too on 7/23. Reopening.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 7•21 years ago
|
||
Ah, I had those diffs in my tree but I forgot to diff them, and thus check them in... Fixed. Thanks for letting me know.
Status: REOPENED → RESOLVED
Closed: 21 years ago → 21 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•