111472 - Menubar/main menu color wrong in XP

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect)

Description

[Blake Ross]

In Windows XP (and in the XP theme), the main menubar and the main menus are all
white.  This is incorrect; in every other app they are gray, like the toolbars.
 However, our context menus are also white, and that is correct -- every other
app's context menus are too.  So it seems like we need to be catching two
different system colors.

Comment 1

[:deanis74]

It looks like we need to use COLOR_MENUBAR for the main menu bar when we're on
XP, and keep using COLOR_MENU for popups.

We should do a check for the windows version and use the appropriate constant at
http://lxr.mozilla.org/mozilla/source/widget/src/windows/nsLookAndFeel.cpp#147

Note that there's also a COLOR_MENUHILIGHT, which is the highlight color in XP
for items on a flat menu bar.

<http://msdn.microsoft.com/library/default.asp?url=/library/en-us/sysinfo/sysinfo_9b1u.asp>

Comment 2

[Joe Hewitt (gone)]

-> shliang

Comment 3

[Joe Hewitt (gone)]

fixed

Comment 4

[Patty Mac]

Verified on windows (2001-12-28-08-trunk)

Comment 5

[:deanis74]

What was the fix, out of curiosity?