Closed Bug 111508 Opened 23 years ago Closed 23 years ago

[xlib] Xlib timer code scares me...

Categories

(Core :: XUL, enhancement, P1)

Product:
Core
Component:
XUL
Platform:
All
Linux
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla0.9.7

People

(Reporter: roland.mainz, Assigned: roland.mainz)

References

Details

Attachments

(1 file, 1 obsolete file)

Better patch for 2001-11-24-08-trunk
53.34 KB, patch
timeless
: review+
Details | Diff | Splinter Review 
Xlib toolkit timer code scares me.
It would be sooo far "simpler"...

I'll file a patch to "fix" that ...
Accepting ...
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → mozilla0.9.7
Attached patch Patch for 2001-11-20-08-trunk (obsolete) — — Splinter Review 

    
    

    
  
Requesting r= ...
Keywords: patch, 
          
            review

    
  
Blocks: 79119
Summary: Xlib timer code scares me... → [xlib] Xlib timer code scares me...

    
    

    
  
too bad there is not a xlib module owner
these kind of bugs need to be looked at not rot for weeks.

    
    

    
  
Comment on attachment 58891 [details] [diff] [review]
Patch for 2001-11-20-08-trunk

I have a better patch now... :-)

New patch in a few mins ...

        Attachment #58891 -
        Flags: needs-work+

    
    

    
  


  

        Attachment #58891 -
        Attachment is obsolete: true

    
  

        Attachment #59144 -
        Flags: review+

    
    

    
  
Fix checked in, marking FIXED.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED

    
    

    
  
I don't use xlibfe (yet), but.... nice clean-up!  =)


    
    

    
  
It isn't "that" nice, we already have a regression. Looks I forgot to remove two
lines of old code which cause nsAppShell to be released manually while a
nsCOMPtr still references it. A nightmare to debug... ;-(
See bug 111922 - patch is there, too ... wanna r= it ... ? :)

    
    

    
  
I see that leaf has r='d it, so I'm spared the embarrassment of reviewing fixes
to fixes that I was admiring in the first place.  :)


    
    

    
  
*** Bug 95408 has been marked as a duplicate of this bug. ***

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: