111689 - pressing enter in file upload control does not submit form

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[Niels Aufbau]

Steps to reproduce:
1. Go to http://validator.w3.org/file-upload.html
2. Type in a filename.
3. Press enter.

Actual result: nothing happens, have to click on "Validate this document" to
submit the form.

Expected result: hitting enter should submit the form, like it does in a normal
textbox.

Comment 1

[TucsonTester3]

Attachment: Reduced testcase

I am also seeing this on
Windows 98
Build ID:  2001121003

Comment 2

[rods (gone)]

->>

Comment 3

[Alexandru Savulov]

setting milestone

Comment 4

[Jesse Ruderman]

See also bug 104449, "Enter does not submit from all form controls".  Bug 104449
specifically mentions dropdown listboxes but no other controls.

Comment 5

[John Keiser (jkeiser)]

Taking.

Comment 6

[Boris Zbarsky [:bzbarsky]]

So what behavior do we want here and in bug 104449?  It's pretty easy to make
file inputs submit, if that's what we want to do...  jst?  peterv?  Thoughts?

Comment 7

[Boris Zbarsky [:bzbarsky]]

Attachment: Something like this

Comment 8

[Boris Zbarsky [:bzbarsky]]

Attachment: Same as diff -b

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 145184 [details] [diff] [review]
Same as diff -b

The change to not check mForm before firing onchange is needed because the
textbox inside the file input doesn't have an mForm.  I think it's more correct
this way in general, though.

Comment 10

[Johnny Stenback (:jst)]

Comment on attachment 145184 [details] [diff] [review]
Same as diff -b

Yeah, I think this is exactly what we'd want. Should we push this in for 1.7?

Comment 11

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 145184 [details] [diff] [review]
Same as diff -b

I think so.  This is certainly safe enough.

Comment 12

[chris hofmann]

Comment on attachment 145184 [details] [diff] [review]
Same as diff -b

a=chofmann for 1.7

Comment 13

[Boris Zbarsky [:bzbarsky]]

Checked in for 1.7