111883 - typesafe way to get style data

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

I'm tired of having to write the same information twice in a way that the
compiler can't check -- the struct ID and the type of the struct.  So I have a
patch for typesafe |GetStyleData| global functions that I'll attach.  On my gcc3
optimized build these (see the test patch that uses it) compile to the exact
same size file.  They need to be tested on other platforms.

Any thoughts?

Comment 1

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: patch

Comment 2

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Attachment: patch that tests both functions

Comment 3

[Pierre Saslawsky]

Comment on attachment 59119 [details] [diff] [review]
patch

It looks fine on the Mac.  With the second patch, the Layout shared lib size
increased by only 57 bytes in a debug build. r=pierre

Comment 4

[David Hyatt]

sr=hyatt.  Lookin' good.

Comment 5

[Chris Waterson]

Comment on attachment 59119 [details] [diff] [review]
patch

sr=waterson (hyatt, too, I think)

Comment 6

[Chris Waterson]

Comment on attachment 59121 [details] [diff] [review]
patch that tests both functions

sr=waterson

Comment 7

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Patches checked in 2001-11-27 21:04 PDT, although I'd like to do a little more
measurement before strongly advocating the use of the new functions all over the
place...

Comment 8

[Cathleen]

-> 0.9.8

Comment 9

[Boris Zbarsky [:bzbarsky]]

So... we've been using the typesafe versions of GetStyleData more and more with
no ill effects, as far as I can tell.  What remains to be done here?

Comment 10

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

The new mechanism in bug 197205 is also typesafe, although different from the
one proposed here.  Thus marking fixed rather than wontfix.