1119784 - Test failure 'The SSL error message contains disabled information...' in testSecurity/testSSLDisabledErrorPage.js

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Teodor Druta]

Module:    testDisableSSL
Test:      testSecurity/testSSLDisabledErrorPage.js
Failure:   The SSL error message contains disabled information - 'An error occurred during a connection to tlsv1-0.mozqa.com. Peer using unsupported version of security protocol. (Error code: ssl_error_unsupported_version) ' should contain 'ssl_error_no_cypher_overlap'
Branches:  default
Platforms: All
Locale:    All
Report:    http://mozmill-daily.blargon7.com/#/remote/report/5bb4668cfa6af53a0ba505835d09cbbd

This test started to fail with the latest nightly. We should skip it.

Comment 1

[Teodor Druta]

Attachment: disablessldisabled.patch

We should skip this test on default ASAP, meanwhile I'll find the regressor.

Comment 2

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 8546612 [details] [diff] [review]
disablessldisabled.patch

Review of attachment 8546612 [details] [diff] [review]:
-----------------------------------------------------------------

::: firefox/tests/remote/testSecurity/manifest.ini
@@ +5,5 @@
>  [testMD5HashSignature.js]
>  disabled = Bug 1109613 - Test failure 'expertContentHeading.getNode(...) is null'
>  [testMixedContentPage.js]
>  [testSSLDisabledErrorPage.js]
> +disabled = Bug 1119784 - Test failure 'The SSL error message contains disabled information...' in testSecurity/testSSLDisabledErrorPage.js

Please remove the test name from the message.

Comment 3

[Teodor Druta]

Attachment: disablessldisabled.patch

Fixed disabled message.

Comment 4

[Teodor Druta]

Attachment: disablessldisabled.patch

:( It seems that my repository wasn't up to date, fixed rejections.

Comment 5

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 8546616 [details] [diff] [review]
disablessldisabled.patch

Review of attachment 8546616 [details] [diff] [review]:
-----------------------------------------------------------------

http://hg.mozilla.org/qa/mozmill-tests/rev/c8250d29b03c (default)

Comment 6

[Teodor Druta]

This is the regressor: https://hg.mozilla.org/mozilla-central/rev/b3f84cf78dc2
Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=703f75b9a9c0&tochange=b3f84cf78dc2

Comment 7

[Teodor Druta]

Attachment: fixssldisabled.patch

Let's unskip this and apply the fix patch.

Comment 8

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 8546640 [details] [diff] [review]
fixssldisabled.patch

Review of attachment 8546640 [details] [diff] [review]:
-----------------------------------------------------------------

Great!

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Teodor Druta from comment #6)
> This is the regressor:
> https://hg.mozilla.org/mozilla-central/rev/b3f84cf78dc2

This is not the real regressor. You would have to dive into the changeset of the merged in branch. If you see from your patch and the changes made the real bug, please add it to the dependency field.

Comment 10

[Teodor Druta]

Regressor: https://hg.mozilla.org/mozilla-central/rev/fec317aa00bc

Bug 1107731 - Upgrade Mozilla 37 to use NSS 3.18

Lines that made our test fail:
https://hg.mozilla.org/mozilla-central/rev/fec317aa00bc#l15.13
https://hg.mozilla.org/mozilla-central/rev/fec317aa00bc#l15.32
https://hg.mozilla.org/mozilla-central/rev/fec317aa00bc#l15.51
https://hg.mozilla.org/mozilla-central/rev/fec317aa00bc#l15.73

Comment 11

[Andreea Matei [:AndreeaMatei]]

Backout skip:
http://hg.mozilla.org/qa/mozmill-tests/rev/58d290548c66 (default)

Landed fix:
http://hg.mozilla.org/qa/mozmill-tests/rev/9666c66c8492 (default)

Thanks Teodor!

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

With the upgrade of NSS to version 3.19.2 via bug 1176097 for ESR31 builds we also hit this test failure on the esr31 branch. 

I transplanted the fix to that branch and all is working fine locally now:

https://hg.mozilla.org/qa/mozmill-tests/rev/d76a2a8414e3 (esr31)