Closed
Bug 112120
Opened 24 years ago
Closed 24 years ago
GetPrimaryFrameFor() cleanup in nsHTML*Element.cpp...
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla0.9.7
People
(Reporter: jst, Assigned: jst)
Details
Attachments
(1 file)
|
31.40 KB,
patch
|
axel
:
review+
|
Details | Diff | Splinter Review |
Currently we have a formcontrol specific GetPrimaryFrame() method in
nsGenericHTMLElement, I've renamed that, removed unnecessary arguments n' done
some cleanup. Patch coming up.
|
Assignee | |
Comment 1•24 years ago
|
||
|
|
Assignee | |
Comment 2•24 years ago
|
||
Reviews?
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.7
|
||
Updated•24 years ago
|
Keywords: mozilla0.9.7,
patch
|
||
Comment 3•24 years ago
|
||
Attachment #59305 -
Flags: review+
Comment on attachment 59305 [details] [diff] [review]
Cleanup...
+ if (formControlFrame) {
+ formControlFrame->QueryInterface(NS_GET_IID(nsIFrame),
+ (void **)&formFrame);
+ }
could you use CallQueryInterface? (frames are still a bit beond me :))
either way, r=sicking
|
|
Assignee | |
Comment 5•24 years ago
|
||
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Component: DOM: HTML → DOM: Core & HTML
QA Contact: stummala → general
You need to log in
before you can comment on or make changes to this bug.
Description
•