1122677 - Disallow request body when method is HEAD/GET

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

This was previously unspecified, but clarified by :annevk. Spec bug https://www.w3.org/Bugs/Public/show_bug.cgi?id=27846

Comment 1

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Attachment: Disallow request body when method is HEAD/GET

Spec bug has been fixed.

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8551993 [details] [diff] [review]
Disallow request body when method is HEAD/GET

Review of attachment 8551993 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.  Flag baku for peer sign off.

::: dom/fetch/Request.cpp
@@ +220,5 @@
>    if (aInit.mBody.WasPassed()) {
> +    // HEAD and GET are not allowed to have a body.
> +    nsAutoCString method;
> +    request->GetMethod(method);
> +    if (method.EqualsLiteral("HEAD") || method.EqualsLiteral("GET")) {

nit: Add a comment that HEAD and GET are guaranteed to be uppercase due to step 14.2 above.

Comment 3

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a76ced5f328c

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/a76ced5f328c

Comment 5

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Gah, sorry I broke protocol there by landing before Andrea's review. Hadn't noticed that flag.