1126447 - nsDateTimeFormatUnix.h:23:14 [-Winconsistent-missing-override] 'FormatTime' overrides a member function but is not marked 'override'

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Daniel Holbert [:dholbert]]

clang 3.6 build warnings, on linux:
{
intl/locale/unix/nsDateTimeFormatUnix.h:23:14 [-Winconsistent-missing-override] 'FormatTime' overrides a member function but is not marked 'override'
intl/locale/unix/nsDateTimeFormatUnix.h:30:14 [-Winconsistent-missing-override] 'FormatTMTime' overrides a member function but is not marked 'override'
intl/locale/unix/nsDateTimeFormatUnix.h:37:14 [-Winconsistent-missing-override] 'FormatPRTime' overrides a member function but is not marked 'override'
intl/locale/unix/nsDateTimeFormatUnix.h:44:14 [-Winconsistent-missing-override] 'FormatPRExplodedTime' overrides a member function but is not marked 'override'
}

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix v1

Comment 2

[(no longer active)]

Comment on attachment 8555425 [details] [diff] [review]
fix v1

blanket r=me for all fixes of this nature across the tree.  :-)

Comment 3

[Daniel Holbert [:dholbert]]

Sweet, thanks!

This and bug 1126438 are actually the last instances of this that I get, locally, outside of skia! :)

Comment 4

[Daniel Holbert [:dholbert]]

Landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/f579eea5dc02

Comment 5

[(no longer active)]

(In reply to Daniel Holbert [:dholbert] from comment #3)
> This and bug 1126438 are actually the last instances of this that I get,
> locally, outside of skia! :)

Don't think for a second that people will stop putting more of these in.  ;-)  I have "fixed" MIR.h at least three times, if not more.

Comment 6

[Daniel Holbert [:dholbert]]

True. I will take full advantage of your blanket-r+ then. :)

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f579eea5dc02