112921 - popup windows, without chrome, should not display tab bar/strip.

Status: VERIFIED FIXED

(SeaMonkey :: Tabbed Browser, defect)

Description

[Neil Pryde]

popup windows, without chrome, should not display tab bar/strip.

Steps to reproduce:
1. start mozilla, or MultiZilla
2. in mozilla go to Menu->Edit-Preferences->Navigator->Tabbed Browsing
3. mark the checkbox 'Hide the tab bar when only one tab is open'
4. click the 'ok' botton
5. visit a site that opens a popup window

current result : popup window without chrome displays the tab bar
expected result: the tab bar should be invisible for chrome less windows

-Neil.

Comment 1

[Neil Pryde]

oops, changing component to Tabbed Browser

Comment 2

[Neil Pryde]

All popup windows for netscapes web based mail displays the tab strip. I dont
think this should be the case.

-Neil.

Comment 3

[Karl Johan Kleist]

Reporter: Please always specify which "Build ID" you're using. Thank you.

Comment 4

[Asa Dotzler [:asa]]

reassign to default tab owner

Comment 5

[Neil Pryde]

"Reporter: Please always specify which "Build ID" you're using. Thank you."

Well that really doesn't matter. This is the case for ALL mozilla builds with
the pref setting to enable the tab strip visibility.

-Neil.

Comment 6

[John Morrison]

works for me 11/30 build.

Comment 7

[Neil Pryde]

John, I use 2001113003 on WinNT4 and still see the tabstrip. Can you please add
some comment what works for you? I don't get it, you don't see that tab strip?

-Neil.

Comment 8

[Neil Pryde]

****, now I see:

3. mark the checkbox 'Hide the tab bar when only one tab is open'

'mark' should be uncheck, damn.

Comment 9

[Neil Pryde]

What I like to see is a check like this:

if( document.documentElement.hasAttribute( "chromehidden" ) ) {
  // here some code to hide tab strip, whatever the state of that pref is!
}
    

Comment 10

[Neil Pryde]

Reopening

Comment 11

[John Morrison]

Ah, right. If it is unchecked (so the tab strip is always shown), then the 
popup window contains a tab strip. Thanks for clearing that up (I was 
wondering how this was supposed to be possible given your initial note).

Comment 12

[David Hyatt]

Reassigning to new component owner.

Comment 13

[jag (Peter Annema)]

820 window[chromehidden~="menubar"] .chromeclass-menubar,
821 window[chromehidden~="toolbar"] .chromeclass-toolbar,
822 window[chromehidden~="location"] .chromeclass-location,
823 window[chromehidden~="directories"] .chromeclass-directories,
824 window[chromehidden~="status"] .chromeclass-status,
825 window[chromehidden~="extrachrome"] .chromeclass-extrachrome

One or more of those should be specified on the tabbar.

toolbar,status,extrachrome?

Comment 14

[jag (Peter Annema)]

nsbeta1, -> 1.0

Comment 15

[jag (Peter Annema)]

*** Bug 130062 has been marked as a duplicate of this bug. ***

Comment 16

[Peter Trudelle]

nsbeta1+ per Nav triage team

Comment 17

[Blake Ross]

Attachment: patch

Comment 18

[Blake Ross]

I think it should be toolbar.  My rationale is that for people who use it,
tabbrowser is an integral part of browsing.  So they probably want it whenever
they've got their navigation bar.  But I welcome input from others.  I'd also be
okay with specifying extrachrome.

Comment 19

[jag (Peter Annema)]

Comment on attachment 74535 [details] [diff] [review]
patch

toolbar seems fine, sr=jag

Comment 20

[Hixie (not reading bugmail)]

r=hixie

Comment 21

[Blake Ross]

Comment on attachment 74535 [details] [diff] [review]
patch

setting r=hixie.
asa said a=asa

Comment 22

[Blake Ross]

Fixed.

Comment 23

[sairuh (rarely reading bugmail)]

vrfy'd fixed using 2002.03.26 comm bits on linux rh7.2, win2k and mac 10.1.3.