113003 - Mac-packaged DOM Inspector fails to install

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect)

Description

[Brad Tiffany]

Build 2001113008 on MacOS 8.6 using the 13MB big blob installer.

Attempting to install the DOM inspector using the custom install option fails
with error -214 (mozilla runs fine otherwise). Relevant part of the install log
appears to be

-------------------------------------------------------------------------------
file:///Mac%20HD/Desktop%20Folder/Mozilla%20Full%20Installer/Installer%20Modules/inspector.xpi
 --  11/30/2001 21:37:01
-------------------------------------------------------------------------------

     DOM Inspector
     -------------

     ** initInstall: 0
     ** addDirectory: -214
     ** ERROR (-214): Register Package: 
     ** ERROR (-214): Register Skin: 
     ** ERROR (-214): Register Skin: 
     ** ERROR (-214): Register Locale: 

     Install **FAILED** with error -240
     Finished Installation  11/30/2001 21:37:01

Comment 1

[Boris Zbarsky [:bzbarsky]]

People are seeing this on mozillazine.org forums...

Comment 2

[Brad Tiffany]

The install.js included with inspector.xpi has the line

  err = addDirectory("", "5.0.0.2001121008", "bin", fProgram, "", true);

but the actually goodies are in the "viewer" folder in the Mac version of
inspector.xpi.  Changing "bin"->"viewer" allowed me to install successfully.

Presumably, then, the fix is to make line 9 of

http://lxr.mozilla.org/seamonkey/source/xpinstall/packager/mac/inspector.jst

point to the right directory in the .xpi?

Comment 3

[Daniel Veditz [:dveditz]]

Reassigning to hewitt for the obvious install-script change (thanks for the
legwork, Brad!). I'm sure he cares about this more than syd :-)

nominating for the 0.9.7 train, it's low-risk/high-gain

Comment 4

[Joe Hewitt (gone)]

Attachment: patch

Comment 5

[Daniel Veditz [:dveditz]]

Curt or Samir, please review this one-line change

Comment 6

[Daniel Veditz [:dveditz]]

Comment on attachment 61764 [details] [diff] [review]
patch

sr=dveditz

Asa: please approve for the branch

Comment 7

[Samir Gehani]

Comment on attachment 61764 [details] [diff] [review]
patch

r=sgehani

Comment 8

[Asa Dotzler [:asa]]

a=asa (on behalf of drivers) for checkin to 0.9.7

Comment 9

[Joe Hewitt (gone)]

fixed on trunk and branch

Comment 10

[K'Trina Medina]

Verified on current Mozilla trunk and branch builds
(Build 2002020405 (0.9.8) and build 2002020608 (trunk))