1133805 - Fix and re-enable test_unregister.html, test_workerUpdate.html and test_workerUnregister.html

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Bug 1060517

Comment 1

[Ryan VanderMeulen [:RyanVM]]

test_workerUpdate was hitting intermittent asserts too in addition to the timeouts.
https://treeherder.mozilla.org/logviewer.html#?job_id=6697595&repo=mozilla-inbound

Comment 2

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

It is quite possible that the fix is a simple undefined error. I'm awaiting several try runs that may fix both these intermittents.

Comment 3

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Attachment: Fix SW intermittents

Based on my try runs this 'a is undefined' error due to non-existent registration seems to be causing all the intermittents. I'm not sure why a JS error was doing that, but the results seem to speak for themselves

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2e061f64f46a

Comment 4

[Andrea Marchesini [:baku]]

Comment on attachment 8566425 [details] [diff] [review]
Fix SW intermittents

Review of attachment 8566425 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/workers/test/serviceworkers/simpleregister/index.html
@@ -36,5 @@
>              }
>            });
>  
> -          navigator.serviceWorker.getRegistration('http://mochi.test:8888/with_star/*')
> -            .then(function(a) {

but in theory this should work, correct? So we have some kind of bug somewhere... right?

Comment 5

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

There is no longer any registration call for with_star scope. Which means 'a' is undefined.

Comment 6

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Ugh, actually ignore this. I just realized the try push had the tests disabled :(

Comment 7

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Attachment: Enable worker update and unregister tests

Comment 8

[Andrea Marchesini [:baku]]

Comment on attachment 8572798 [details] [diff] [review]
Enable worker update and unregister tests

Review of attachment 8572798 [details] [diff] [review]:
-----------------------------------------------------------------

if green on try!

Comment 9

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=68f755cd7117

Comment 10

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/85a9d5f966ac

Comment 11

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/85a9d5f966ac