113427 - Can't open subfolder of context-"Expand"-ed personal toolbar folder

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect, P3)

Description

[[e-mail]]

Using Build ID: 2001120303
Steps to reproduce problem:
1. Create/use a folder in your personal toolbar folder
2. Create/use a subfolder in that folder
3. Create/use a bookmark in that subfolder
4. Right-click the folder on the personal toolbar, and select "Expand"
5. Click on the subfolder

Expected results: subfolder opens.

Actual results: subfolder does not open. Also the title bar flashes?

Comment 1

[[e-mail]]

Attachment: Proposed patch

Comment 2

[Chris Lyon]

Whoa, I thought the Expand menu item was gone way back in build 2001092803.  
Who brought it back?  Should we reopen Bug 86649? (one of yours, Neil)

Comment 3

[[e-mail]]

Thanks for pointing that out, Chris.
But if we're keeping Expand, then this is actually a dup of bug 83141.

Comment 4

[[not reading bugmail]]

works for me in build 12-16-08 w2k.

Comment 5

[Peter Trudelle]

mass reassign of pchen bookmark bugs to ben

Comment 6

[Chris Lyon]

removing self from cc list

Comment 7

[Ian Pottinger]

Is this still and issue?  Works for me with Mozilla 0.9.9+ [build ID 2002041111]
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:0.9.9+) Gecko/20020411 

Comment 8

[[e-mail]]

Sorry, but it's still a problem for me on Windows 9x, build 2002041103.

Comment 9

[[e-mail]]

*** Bug 140019 has been marked as a duplicate of this bug. ***

Comment 10

[[e-mail]]

I duplicated bug 140019 against this bug because the fix is the same.

Comment 11

[Steven Neil Groginsky]

 Bug 140019 is not a duplicate of this bug.  This bug (113427) refers to a
subfolder of a subfolder of Personal Toolbar not opening when clicked.

Bug 140019 refers to closing a subfolder of Personal Toolbar opened with
leftclick vs. not same behavior when opened with rightclick->expand.

Please decide if you want two separate bugs and adjust/not adjust accordingly.

Comment 12

[Steven Neil Groginsky]

Oops.  Didn't see that fix is the same.  Sorry, ignore the last message.

Comment 13

[Brian Z Jones]

If I understand the problem correctly, this seems to work fine now, under Win2K,
BuildID: 2002052906.

Comment 14

[[e-mail]]

So, Brian, are you going to give me a Windows 2000 PC?

Comment 15

[Pierre Chanial]

Comment on attachment 60310 [details] [diff] [review]
Proposed patch

I'd prefer to let bryner review this one since I think it's a workaround.
Btw, I think it would be simpler to call showPopup instead of QI'ing the popup
in this file.

Comment 16

[[e-mail]]

Fix was checked in by caillon.

pch: I didn't write that QI, and showPopup calls it anyway.

Comment 17

[Pierre Chanial]

Neil: yes, np. the enhancement suggestion (really minor) was that if helper
functions exist, let's use them and fix the helper function so that all callers
would be correct.
My concern was about the use of a timer, I didn't feel myself competent enough
to review an event bug that relates with threads and because I suspect it is a
symptom of a deeper issue that the event module owner (bryner) should be aware of.

Comment 18

[[e-mail]]

Well it might be a menu issue - there used to be a bug with the tree
columnpicker when it fired on a mousedown event (it works fine now using a
command event).