113498 - .src on new Image()'s not absolute.

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[shrirang khanzode]

on build 1203, win NT

go to the above site 
move the mouse over the links at the center of the page where it says "Flight 
Status", "Airport Guide" ...select any 'sub-link' from these link and click..

observe that no page loads.

Comment 1

[Mats Palmgren (inactive)]

Attachment: Reduced testcase

Comment 2

[Mats Palmgren (inactive)]

document.ImageName.src is the problem.
--> Evangelism

Comment 3

[Jacek Piskozub]

Another German site mis-componented as Central Europe.

-> Europe: West

Comment 4

[Jacek Piskozub]

Now really changing to Europe: West (where Germany belongs according to Mozilla
tech evanelism work division)

Comment 5

[Tristan Nitot]

Confirming with Moz 097.
Contact: [e-mail]

Mats : can you elaborate why this is not working, and suggest a fix, so I can
send this to the webmaster? Thanks.

Setting P2.

Comment 6

[Mats Palmgren (inactive)]

I am really sorry, I see now that my first analyse of the problem is wrong.
This is actually a Mozilla bug. The page uses javascript to create a bunch of
Image objects initialized with object.src="/foo.gif", these are later used to
determine which "link" was clicked on and select the correct URL to go to.
This later test is of the form: if (document.imgName.src == object.src) ...
This is where Mozilla goes wrong, the document.imgName.src will be an absoulte
URL ("http://www.frankfurt-airport.de/foo.gif") but the object.src is relative
("/foo.gif") so the test will always be false.

Sending back to Browser for further triage. I will attach a minimal testcase to
illustrate the problem.

The testcase works fine in IE6, Opera 5.12, Navigator 3.04 and 4.7, and Mozilla
m18 (2001-01-05), but not in Mozilla 2002-01-19-08 (trunk). All on Windows 98.

Comment 7

[Mats Palmgren (inactive)]

Attachment: Minimal testcase

Comment 8

[Johnny Stenback (:jst)]

Attachment: Proposed fix, also eliminates on member from nsHTMLInputElement that's not really needed.

Comment 9

[Johnny Stenback (:jst)]

Attachment: Proposed fix, also eliminates on member from nsHTMLImageElement that's not really needed.

Oops, I attached the wrong patch, here's the right one...

Comment 10

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 66032 [details] [diff] [review]
Proposed fix, also eliminates on member from nsHTMLImageElement that's not really needed.

in nsHTMLImageElement::Initialize please remove the NS_SUCCEEDED(result) from

  if (NS_SUCCEEDED(result) && (argc > 0)) {

Comment 11

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

err, other then that, r=sicking

Comment 12

[Johnny Stenback (:jst)]

Attachment: fix sicking's nit (by rearranging some code)

Comment 13

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 66041 [details] [diff] [review]
fix sicking's nit (by rearranging some code)

sorry for taking so long :(

Comment 14

[Johnny Stenback (:jst)]

Fixed (rs=[e-mail])

Comment 15

[Sivakiran Tummala]

verified fixed, build 03-22-05