11376 - Plugin streams never get initialized (OnProgress is never called)

Status: VERIFIED FIXED

(Core :: Networking, defect, P3)

Description

[av (gone)]

Warren, as you suggested I filed a bug and assigned it to you. You will need our
old npavi.dll plugin to use this test case. But any audio plugin will not play
too. This happens after Necko landing so I suspect something changed in
streaming API which needs to be adjusted in plugin code. I will continue to look
at it too these days.

I marked it critical but this could be M9 stopper. Also component probably
should be changed to Plugins.

Comment 1

[Warren Harris]

Where can I get npavi?

Comment 2

[av (gone)]

I'll send it to you.

Comment 3

[Warren Harris]

I spent some time looking into this, and it doesn't look like a necko bug.
nsPluginStreamListenerPeer::Initialize is never getting called, and
consequently mPStreamListener is never getting set. When necko delivers the
plugin data to nsPluginStreamListenerPeer::OnDataAvailable, it just bails at
nsPluginHostImpl.cpp line 1060.

I think av should debug this from here.

Comment 4

[chris hofmann]

can I get an update on this later today?

Comment 5

[av (gone)]

I'll give an update by the end of the day

Comment 6

[av (gone)]

There is something called ProxyProgressEvent, and mPStreamListener used to be
set upon this event. Here is stack from the days it worked:

nsPluginStreamListenerPeer::SetUpStreamListener(nsIURI * 0x0245c470) line 1156
nsPluginStreamListenerPeer::OnProgress(nsPluginStreamListenerPeer * const
0x0245da80, nsIURI * 0x0245c470, unsigned int 0, unsigned int 180224) line 1012
+ 12 bytes
nsDocumentBindInfo::OnProgress(nsDocumentBindInfo * const 0x0245d9d0, nsIURI *
0x0245c470, unsigned int 0, unsigned int 180224) line 1692 + 30 bytes
OnProgressProxyEvent::HandleEvent(OnProgressProxyEvent * const 0x02444040) line
537
StreamListenerProxyEvent::HandlePLEvent(PLEvent * 0x02444044) line 473 + 12
bytes
PL_HandleEvent(PLEvent * 0x02444044) line 493 + 10 bytes
PL_ProcessPendingEvents(PLEventQueue * 0x0105f490) line 454 + 9 bytes
_md_EventReceiverProc(HWND__ * 0x000b0194, unsigned int 49293, unsigned int 0,
long 17167504) line 912 + 9 bytes

Something changed, and above does not happen any more. Probably event is not
sent. Can somebody explain me what has changed and what should be done?

Comment 7

[Warren Harris]

I see. We're not getting the OnProgress notification. This either falls under
Rick's domain (docloader related), or Gagan's (http protocol not sending it).
Reassigning to Rick.

Comment 8

[leger]

We're gonna release note this one for M9.  paulmac, ask verah to do in BOLD.
Moving to M10

Comment 9

[Paul MacQuiddy]

release note added!

Comment 10

[rpotts (gone)]

I've just checked in the fix for this.

It looks like plugins that do not rely on the cache are working again.  However,
plugins that download their data to the cache and then open up the cache file
are *still* broken until a cache is hooked into necko...

Comment 11

[av (gone)]

Rick could you please clarify your last comment? What should be done to fix
this?

Comment 12

[rpotts (gone)]

I believe that some plugins used "stream as file" or some such thing.  I think
that this caused the stream to be downloaded into the cache and then opened up
once all the data was there...

Until we have a necko cache, there's not too much we can do to support this
mechanism...

Comment 13

[Eli Goldberg]

Assigning QA contact.

Comment 14

[Paul MacQuiddy]

shrir is king of plugins

Comment 15

[leger]

Bulk move of all Necko (to be deleted component) bugs to new Networking

component.

Comment 16

[shrirang khanzode]

Setting QA contact, [e-mail]

Comment 17

[Tom Everingham]

verified:
NT 2000070508

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/456ff5ddc60d
[components] For https://github.com/mozilla-mobile/android-components/issues/11376: Add a typealias in MetricAliases for UrlMetricType.
https://hg.mozilla.org/integration/autoland/rev/81aebe0a42be
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11376  - Reverse tabs list order (https://github.com/mozilla-mobile/fenix/pull/16245)