114112 - When indenting text contained in two separate table cells, a <BR> is added for each blockquote tag.

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P2)

Description

[TucsonTester1]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Win98; en-US; rv:0.9.6+) Gecko/20011206
Netscape6/6.1b1
BuildID:    2001120303

If text in multiple table cells is selected and then indented, each time the
blockquote tag is added, an additional <BR> tag is added too. 

Reproducible: Always
Steps to Reproduce:
1. Launch Composer rev. 2001120303
2. Create a new table with 1 column and 4 rows
3. Enter text into each cell then CTRL+click to select each cell 
4. Click repeatedly on the INDENT button on the toolbar

Actual Results:  All of the text will be placed in the bottom-most cell and then
everytime the indent button is clicked, the text will indent but the cell will
get longer as a <BR> tag is added each time the blockquote tag gets added. If
the OUTDENT button is then used to try and undo this, the blockquote tags get
removed correctly but all of the extra <BR> tags remain. From here, if you place
the cursor at the bottom of the cell and start typing, the text will actually be
entered one character on top of the other until it gets up to a line that has
text already on it. 

Expected Results:  The text should stay in its respective cells and the INDENT
button shouldn't add additional linebreaks. 

I realize that the bug describing the text all going into the same cell has been
reported, but I couldn't find reports of the subsequent behavior so here it is :) 

Regarding the steps to reproduce, it seems that if each table cell is select via
CTRL+A or Table>Select>Table and then the indent is applied, a rather different
bug is revealed. In this case, the table will shrink inward from the left and
right edges each time the indent button is clicked until it can't shrink anymore
and then will start indenting the whole table. 
Also, if the cells are selected and then the indent is added via
Format>Paragraph>Blockquote a third bug is seen. What happens here is that the
table completely dissapears and each line of text is spaced out about 10 lines
apart. Most of the html for the table remains although the <TD> tags are gone. 
Let me know if I should report these separately.

Comment 1

[Syd Logan]

wheee!

Comment 2

[Joe Francis]

This is pretty low priority.  Most users dont even know about cell selection 
mode.  However, playing with this I find a more important bug: just select across 
the first three cells (normally) and indent.  The text from first three cells all 
go into third cell.  

Comment 3

[TucsonTester1]

apparent in mac os x build 2001121805. changing platform/os to all.

Comment 4

[Syd Logan]

seems like users might run into this, plussing

Comment 5

[Kevin McCluskey (gone)]

Bulk moving all nsbeta1+ bugs which were targetted after Mozilla1.0 to Mozilla1.0

Comment 6

[Joe Francis]

pri = 2 for original 1.0 EB+ bugs

Comment 7

[Joe Francis]

Attachment: patch to nsHTMLEditRules.cpp

Simple fix.  When tossing nodes into blockquotes, we check to see if we have
crossed a table element boundary.  If we have, we make a new blockquote.

Comment 8

[kinmoz]

Comment on attachment 74663 [details] [diff] [review]
patch to nsHTMLEditRules.cpp

sr=[e-mail]

+	   PRBool bInDifTblElems;
+	   res = InDifferentTableElements(curQuote, curNode, &bInDifTblElems);

Do we need a comment that explains why InDifferentTableElements()
is ok to call with elements that might not be in tables at all?

Do we need to check the return val of res or init bInDifTblElems?

Comment 9

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 74663 [details] [diff] [review]
patch to nsHTMLEditRules.cpp

Call me paranoid, but you should check the return value of
InDifferentTableElements(),
check the return value of calls to GetParentNode()
in InDifferentTableElements()
and initialize *aResult there too.

r=glazman with that

Comment 10

[Asa Dotzler [:asa]]

Comment on attachment 74663 [details] [diff] [review]
patch to nsHTMLEditRules.cpp

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 11

[Joe Francis]

fixed on trunk

Comment 12

[michael wendell]

VERIFIED on Win 98 using 03-22 trunk build.