11412 - implement 'remove from history' (can't delete items from window)

Status: VERIFIED FIXED

(Core Graveyard :: History: Global, defect, P3)

Description

[Chris Waterson]

Cannot currently remove history entries. Implement this feature!

Comment 1

[Chris Waterson]

Sliding non-critical tasks

Comment 2

[leger]

Updating QA contact

Comment 3

[Chris Waterson]

-> mfuture

Comment 4

[Ben Bucksch (:BenB)]

*** Bug 47550 has been marked as a duplicate of this bug. ***

Comment 5

[sairuh (rarely reading bugmail)]

unless i'm confusing this with another feature, this was in 4.x (at least in
win32 --doesn't seem to work/be active on Mac or linux 4.7x).

adding relnote kw/notes, since the menu item is present in mozilla/6.0, but is
non-functional.

Comment 6

[Blake Ross]

waterson just did clear history.  deleting single items shouldn't be much more 
difficult, says the guy who has no clue...

Comment 7

[Dave Corrie]

*** Bug 58801 has been marked as a duplicate of this bug. ***

Comment 8

[Blake Ross]

*** Bug 58801 has been marked as a duplicate of this bug. ***

Comment 9

[Blake Ross]

*** Bug 59237 has been marked as a duplicate of this bug. ***

Comment 10

[Blake Ross]

updating summary to catch more dups

Comment 11

[Kathleen :Brade]

note: it's bad that the menu item "delete" is currently available to users but
selecting it doesn't do anything.

Comment 12

[Raghu Sakleshpur]

Adding sun tracking string.

Comment 13

[Kristi Fredrickson]

Adding to "Changed Features" section of "Upgrading to Netscape 6" (Migration 
Guide)

Comment 14

[R.K.Aa.]

probably stating the obvious, but trying to delete entries in history window
only spawns this in console:

************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE)
[nsIRDFContainer.Init]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location:
"JS frame :: chrome://communicator/content/bookmarks/bookmarks.js :: doDelete ::
line 504"  data: no]
************************************************************
An error occurred executing the cmd_delete command

(on linux, build 2000113006)

Comment 15

[Radha on family leave (not reading bugmail)]

I presume you all are talking about the Tasks->Tools->History window. If so,
this will go to Alec Flett.

Comment 16

[Alec Flett]

coolness, I like this idea

Comment 17

[Alec Flett]

ok, I have a fix for this, attaching a patch shortly.

the patch is pretty mammoth because it refactors a lot of code... the actual
feature was fairly trivial (but the nice thing is that nsGlobalHistory is
actually smaller after the patch is applied, even with this feature implemented)

Comment 18

[Alec Flett]

Attachment: proposed patch, with lots of refactorization

Comment 19

[Alec Flett]

looking to radha for review, waterson for super review

Comment 20

[Chris Waterson]

Sexy. r=waterson

Comment 21

[Radha on family leave (not reading bugmail)]

r=radha

Comment 22

[Viswanath Ramachandran]

nav triage team: nsbeta1 p3

Comment 23

[Alec Flett]

fix is in

Comment 24

[Keyser Sose]

Reopening..
This is not fixed on Linux 20010123, Win98 20010123 (thanks sumner2 on #mozillazine)

Comment 25

[Alec Flett]

this works fine for me on linux, 2001012408 build.. I can delete or cut.

Comment 26

[Stephan Niemz]

*** Bug 66546 has been marked as a duplicate of this bug. ***

Comment 27

[Stephan Niemz]

*** Bug 66546 has been marked as a duplicate of this bug. ***

Comment 28

[Kathleen :Brade]

reopening bug; I can't deleting items from my history consistently (Mac mozilla 
debug build from today after brendan's backout).

I tried the menu as well as the delete (backspace) key.  I think I did manage to 
delete one item after resorting the contents but I couldn't delete anything after 
that.

Comment 29

[Blake Ross]

I think this is just some nsTreeController oddness.

Comment 30

[Paul Chen]

Marking nsbeta1+, reassinging to pchen to take a look on mac

Comment 31

[djk]

Using 2001031008 on Win98se

I can delete history items with either <del> or edit->delete.

However, for the change to be reflected, you have to force a refresh of the
history item's folder (either closing/opening it or closing history and reopening).

I got a bit of unreproducible behavior where a folder which I deleted an item
from would not open up again.  Closing and reopening the history window did not
clear it up.

Comment 32

[Reinout van Schouwen]

Try right-clicking on an history item. Instead of the expected context sensitive
popup menu only a little empty square appears. (Moz 0.8.1, Linux).

Comment 33

[Paul Chen]

Moving to mozilla0.9.1, though I think this is a dup of some history bug alecf has.

Comment 34

[Blake Ross]

This used to work; cc'ing alec so he's informed.

Comment 35

[Alec Flett]

this broke when we switched to hierarchical history.. basically we need to make
sure to unassert the deleted URL from a few of the 'well-known' find URIs.. look
at NotifyFindAssertions (or whatever it's called) - probably need to do the
reverse of that.

I should add that the delete-by-domain and delete-by-hostname feature is also
_sort_of_ broken in the same way this one is... but the solution to that is to
simply remove the hostname from a few of the toplevel find uris... someone want
to file a seperate bug?

Comment 36

[Blake Ross]

I thought it broke with hierarchical history also, and was going to say that, 
but that landed after ~1/23, no? *shrug*

Comment 37

[Viswanath Ramachandran]

as discussed in team meeting, moving all Nav+ team members nsbeta1+ P3 bugs from 
mozilla0.9.1 to mozilla0.9.2. 

Comment 38

[Alec Flett]

*** Bug 76947 has been marked as a duplicate of this bug. ***

Comment 39

[Claudius Gayle]

this bug was fixed(delete was implemented) a while ago and then regressed. While in its regressed
state bug 82571 was filed. Technically this bug was fixed and we're just looking at a new regression.

I can't very well mark it fixed and it's certainly not a dupe of the other so I'm just going reassign
it to Blake (the correct owner of 82571) and make the new one a dupe.

The issue of the deleted item not displaying as such(proving that delete was implemented btw)
until the twisty of its container was collapsed and expanded again became bug 82158.

Comment 40

[Claudius Gayle]

*** Bug 82571 has been marked as a duplicate of this bug. ***

Comment 41

[Todd Pringle]

This is fixed, right Alec?

Comment 42

[Alec Flett]

yep.. taking back from blake

Comment 43

[Alec Flett]

re-marking fixed

Comment 44

[Kathleen :Brade]

verify on my mac debug build from today; HURRAY!!!!!!

Comment 45

[Claudius Gayle]

Am i missing something? With a 2001062108 Mac build and a 2001062111 Linux build I can't
delete any single history item from anywhere in any fashion. Global window+Sidebar from the menu
and from the keyboard no results whatsoever. I did see any errors to the console either.
REOPENING.

Comment 46

[Alec Flett]

augh! this worked!
This is also failing for me on windows 2001-06-21-04

I really want to know WTF is going on.

Comment 47

[Alec Flett]

augh! this worked!
This is also failing for me on windows 2001-06-21-04

I really want to know WTF is going on.
I'm getting an error message on the console "An error occured executing the
cmd_delete command"

Comment 48

[Alec Flett]

strangely, this seems to work in my tip build.. *sigh*

Comment 49

[Alec Flett]

ok, more updates, with today's Linux builds:

mozilla tip nightly: works
netscape tip nightly: broken
mozilla branch nightly: works
netscape branch nightly: broken

so it appears to be something specific to the netscape builds.. MAYBE its a
packaging issue? I don't know.

Comment 50

[Blake Ross]

Yeah.  Works in my homegrown builds.  When I try to delete in a comm nightly, I 
get this js error:

Error: RDF has no properties
Source File: chrome://global/content/nsTreeController.js

Comment 51

[Alec Flett]

ah HA! did you get a source line with that?

Comment 52

[Blake Ross]

Oops, yeah.  324.

Comment 53

[Alec Flett]

Attachment: hack fix

Comment 54

[Alec Flett]

ok, "RDF" is SUPPOSED to be a global variable in this file, and for some reason
is not... I've attached a hacky fix for the 0.9.2 branch. Can I get a
review/super review?

Comment 55

[Kathleen :Brade]

r=brade

Comment 56

[Blake Ross]

Hmm.  Scary.  Cc'ing Brendan.  Copy is in the same boat (as is paste, but 
history is readonly), is it running into this problem too?

sr=blake

Comment 57

[Alec Flett]

removing relnote-user because I fully expect to fix this

Comment 58

[Asa Dotzler [:asa]]

pushing out. 0.9.2 is done. (querying for this string will get you the list of
the 0.9.2 bugs I moved to 0.9.3)

Comment 59

[Alec Flett]

ok, fix checked into the branch. removing extraneous keywords.
leaving bug open so we can figure out what is really going on.

Comment 60

[Viswanath Ramachandran]

nav triage: we can postpone this work now, -> m1.0

Comment 61

[Blake Ross]

Does copy work?

Copy is in the same situation as delete. I don't understand why it would.

Comment 62

[Chris Lyon]

*** Bug 89927 has been marked as a duplicate of this bug. ***

Comment 63

[Blake Ross]

doh doh doh doh doh

I wish someone had read my 7/2 comment.  Copying is indeed broken on the branch.

Comment 64

[Paul Chen]

nav traige team:

Would like to fix this for 0.9.4. Reassigning to [e-mail]

Comment 65

[Blake Ross]

This is fixed with outliner history.

Brendan, you may want to look into why the previous js wasn't working?

Comment 66

[Brendan Eich [:brendan]]

I can't say why RDF was not found in nsSessionHistory_delete's scope parent:
perhaps the window in which the variable was a property had its scope cleared by
DOM code?

Someone get this in a debugger and drag me ove from waterson/cathleen land --
I'm in tomorrow during the day.

/be

Comment 67

[Claudius Gayle]

VERIFIED Fixed with 20010907 builds. ther are still some issues with updating
the view after delete in the "old skool" view but that's for another bug...