114215 - Dragging a bookmark on closed folder in sidebar deletes it

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[NilsE]

This must be new in the last couple of days, maybe related to Blake's outliner
stuff (see related bug 113660).

This is on Linux CVS build, 2001-12-80, 07:00 UTC, RH 7.1.

Dragging an existing bookmark in the bookmark sidebar over a *closed* folder, it
will be deleted. This is reproducable.

To repeat:

1. Open bookmark sidebar
2. Drag some bookmark over a closed folder icon. Release.
3. Observe it's gone. You have been warned!

Expected result:
Bookmark should be moved into that folder.

Observed result:
Bookmark is gone.

Note: dragging a bookmark into an opened folder works. Also dragging a bookmark
from the URL bar over a closed folder in the bookmark sidebar works.

In the faulty case, the following warning can be observed on the console:

************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE)
[nsIRDFContainer.Init]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location:
"JS frame :: <unknown filename> :: anonymous :: line 129"  data: no]
************************************************************

Comment 1

[NilsE]

Adding keyword.

Comment 2

[Boris Zbarsky [:bzbarsky]]

To blake.  Which part of "This is a work in progress, please do not file bugs on
it yet" do people not understand?

Comment 3

[Blake Ross]

Umm...hmm. Can anyone else reproduce? The bookmark is appended to the end of 
the folder, as expected, for me.

Comment 4

[NilsE]

To correct myself after a lot of more testing: not always reproducable, but in
most cases (ca. 80% so far). Most reliably if you create a new BM folder that
then still hasn't got either a [+] nor a [-] box next to it. Drag sth. on it,
and for me the bookmark is gone. Just confirmed with mozilla.org's nightly
2001120806 installer build. [NB. The bookmark is really gone, as a look at
bookmark.html shows. Folder is empty. However, after a lot of creating and
deleting I got a bunch of bookmarks at the end of my bookmark file that aren't
displayed anymore. But that's another not-so-serious issue, and won't file a bug
on that. Promise.]

Comment 5

[alge]

Can repro with 2001120708/linux. 4 out of 4 bookmarks disappeared.

Comment 6

[Boris Zbarsky [:bzbarsky]]

*** Bug 114663 has been marked as a duplicate of this bug. ***

Comment 7

[André Dahlqvist]

Are you guys sure that you're not seeing bug 114256? (read it to the end)

Comment 8

[André Dahlqvist]

I can confirm that this happens too with 2001-12-11-08 on Linux. It happens
reliably if I create a new folder and drag bookmarks to it directly.

Comment 9

[André Dahlqvist]

Heh, I take that back. It ended up in the folder above it just like in my bug
bug 114256.

Comment 10

[Tobias B. Besemer [:BesTo] (QA)]

Please have a lock at my Bug #114663.
Can it be that the bookmarks that seems lost are still anywhere ???

Comment 11

[NilsE]

No, the bookmarks are gone. I've tested it in the following scenario:

1. Open bookmarks in sidebar, create empty new folder at the bottom
2. Create a new bookmark below it. Verify in bookmarks.html that the new
bookmark is indeed at the right location.
3. Now drag the new bookmark on the empty folder just above. The bookmark
disappears from view. A check of bookmarks.html shows that it is still there
*below* the folder in the *old* location, but not visible in the sidebar.
4. Even if you try to open the new folder, the bookmark is not in there.
5. Exit Mozilla and check bookmarks.html. *Now* the bookmark is really gone, as
if deleted. 

That's why this is a dataloss, and the difference to bug 114256 is that the
bookmark didn't end up in another folder. Just confirmed again with today's build.

Comment 12

[Tobias B. Besemer [:BesTo] (QA)]

NilsE: Please read:
http://bugzilla.mozilla.org/show_bug.cgi?id=114256#c9
It can help some people to save there bookmarks.

Comment 13

[[not reading bugmail]]

this also affects the manage bookmarks code... its not just sidebar.  I just
tried in 12-14 w2K build to verify the problem in bug 110578 and seen this bug.
 I was dragging a folder and trying to drop it on a closed folder, it expanded
the closed folder, but the bookmark folder I was trying to move, disappeared,
and is gone, deleted. :)

Comment 14

[[not reading bugmail]]

it used to be that in 12-6 or 12-7 build a moved bookmark showed it listed at
the bottom of the bookmark list.  maybe the code that blake cleaned up after
that also removed the code that actually puts the bookmark back in the file
after a move.

Comment 15

[[not reading bugmail]]

Can everyone attempt to try out my theory here.. I've deleted the installation
for the builds before 12-10.. but 

try build 12-05, 12-06, 12-07 and see if this problem exists.. maybe like I
said, some cleanup actually removed the functionality.

Comment 16

[[not reading bugmail]]

should add regression while we are at it :)

Comment 17

[[not reading bugmail]]

see bug 113660 comment 3  for more on moving bookmarks & deletion.

Comment 18

[basic]

seeing this on win32 too

Comment 19

[Marcus Bauer]

Does not only delete single bookmarks but also complete folders. Severity should
imho be blocker and target milestone set to 0.9.7.

Comment 20

[basic]

this also happens in the bookmarks manager with bookmarks/folders/seperators.

Note that I can delete bookmarks by dragging it into the "Inported IE Favorites"
folder and get this error.

Error: [Exception... "Component returned failure code: 0x80070057
(NS_ERROR_ILLEGAL_VALUE) [nsIXULOutlinerBuilder.getResourceAtIndex]"  nsresult:
"0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: <unknown filename>
:: anonymous :: line 128"  data: no]
Source File: 
Line: 128

I've also found that if the bookmark was positioned before (above) the folder.
dragging it into the folder works, but if it is positioned after the folder it
does not.

Comment 21

[basic]

Another thing is that dragging from folder to folder seems to be fine, this only
happens when dragging from "root".

Comment 22

[[not reading bugmail]]

Blake, it seems the bookmarks went from one build (as in bug 114256) it was just
moving bookmarks in weird places (even in bookmark manager) to deletion and
moving in weird places in another build.

Comment 23

[[not reading bugmail]]

I just grabbed build 12-08 and it has some really scary behavior.. it deletes,
moves, copies, puts them in the wrong folder, and even cant delete them, or move
them sometimes.. (this build, or 12-7, I believe has the updating after you do
an operation but doesnt visually update changes till you restart, (or possibly
close and reopen bookmarks?) Anyway. I didn't have to import any bookmarks to
try this out.  And depending whether you moved them up or down it doesnt
different behavior.  

Blake, 

I'm curious about the code for this? Do you a link to LXR file for the bookmarks
manager that works on these operations?

Comment 24

[basic]

scratch that "root" comment I made earlier. It happens also in folders but only
when I drag to subfolders and only when dragging "up" not "down".

Dennis: I suspect that the other things you are seeing are due to the weird
state this drag deletion bug causes.

btw I'm currently testing this with build 2001121508 win32

Comment 25

[Blake Ross]

Attachment: patch for dataloss/drop issues

Comment 26

[Blake Ross]

Attachment: patch for dataloss/drop issues

Comment 27

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 62120 [details] [diff] [review]
patch for dataloss/drop issues

sr=[e-mail]

Comment 28

[André Dahlqvist]

I can verify that this patch fixed bug 114256.

Comment 29

[Asa Dotzler [:asa]]

a=asa (on behalf of drivers) for checkin to 0.9.7

Comment 30

[Joe Hewitt (gone)]

Comment on attachment 62120 [details] [diff] [review]
patch for dataloss/drop issues

r=hewitt

Comment 31

[Blake Ross]

fixed on branch and trunk.

Comment 32

[Alex Vincent [:WeirdAl]]

v Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.0.0) Gecko/20020530