114286 - No way to determine if a http request was a 304 or not.

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect, P3)

Description

[Stuart Parmenter]

There is no way to figure out if a http request got a 304 response, because in 
nsHttpChannel::ProcessNotModified(), it deletes mResponseHead (which had 304 
set on it) and replaces it with mCachedResponseHead which has 200 set.  It then 
proceeds to set mCachedContentIsValid, which is really what I want access to.

Comment 1

[Darin Fisher]

exposing mCachedContentIsValid would give you only 304 cases, but any case when
the cache is being read.  this is probably sufficient for what imglib needs, right?

Comment 2

[Darin Fisher]

Attachment: v1.0 patch

this patch does two things:

1) adds nsICachingChannel::isFromCache() method to indicate whether or not a
channel's data is coming from the cache.

2) makes nsHttpChannel not discard its cache entry when canceled if its cache
entry is simply being read.

Comment 3

[Darin Fisher]

pavlov: does this do the trick for you?  if so, can i get an r=?  thx!

Comment 4

[Stuart Parmenter]

Comment on attachment 61526 [details] [diff] [review]
v1.0 patch

r=pavlov

Comment 5

[Scott MacGregor]

Comment on attachment 61526 [details] [diff] [review]
v1.0 patch

sr=mscott

Comment 6

[Darin Fisher]

fixed-on-trunk