114503 - Need keyboard shortcuts for Labels

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[kmurray1115]

We should give users the ability to use a simple keystroke (like 1-5) to label
messages. Currently, the Alt+m+l+# approach is not very efficient.

Comment 1

[scottputterman]

reassigning to ssu.

Comment 2

[Sean Su]

I will need Jennifer's input on what the keyboard shortcuts should be.

Comment 3

[kmurray1115]

Do we use the 1-5 keys for anything in the thread pane today? 

Comment 4

[jglick]

http://www.mozilla.org/projects/ui/accessibility/mozkeyplan.html

Looks like the 1-5 keys are available. Cc'ing Aaron for his opinion on this 
idea. Will it be too easy for users to accidentally mark a message with a label?

Comment 5

[kmurray1115]

Looks like we'll need 0 (zero) as well to unmark a label.

Comment 6

[Sean Su]

Attachment: patch v1.0

adds shortcut key mnemonics or the labels commands (keys 0-5).

Comment 7

[Aaron Leventhal]

Responding to jglick's comment #4: I'm fine with this, nothing destructive is
happening.

Comment 8

[Sean Su]

Attachment: patch that adds shortcut keys access to setting labels

This patch only adds the shortcut support to setting the labels for messages,
but does not show the access keys in the labels menus.

Comment 9

[timeless]

Comment on attachment 63868 [details] [diff] [review]
patch that adds shortcut keys access to setting labels

please don't use <key key="."/>

either use:
charcode
The character that is must be pressed. This should be set to a displayable
character.
or
keycode
For keys that do not have displayable characters, such as the enter key or
function keys, use this attribute, instead of charcode. Valid
keys are listed here.
[this documentation borrowed from http://www.xulplanet.com ]

Comment 10

[Sean Su]

Attachment: patch that uses charcode= instead of key=

Comment 11

[Scott MacGregor]

Comment on attachment 63994 [details] [diff] [review]
patch that uses charcode= instead of key=

sr=mscott

Comment 12

[Sean Su]

patch checked in.

Comment 13

[laurel]

OK using jan09 commercial trunk build: win98, linux rh6.2.

Comment 14

[laurel]

OK jan09 commercial trunk build: mac OS X