114550 - Mac Installer incorrectly calculates disk space

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect)

Description

[Stuart Moore]

The installer for the current full install (MacMozillaFullInstall.sea.bin

) from 12/10/2001 incorrectly calculates the available space on the disk. The
result is a large negative number that won't allow the install to proceed.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Sounds like 64-bit issues...  How big is the disk?

Comment 2

[Boris Zbarsky [:bzbarsky]]

*** Bug 114626 has been marked as a duplicate of this bug. ***

Comment 3

[Joel Chan]

The last build which did not have this problem was 2001-12-10-08.

Comment 4

[Daniel Veditz [:dveditz]]

The only change in the mac installer recently has been the conversion to CW7 --
could the new CodeWarrior process math differently?

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=mozilla%2Fxpinstall%2Fwizard%2Fmac&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=month&mindate=&maxdate=&cvsroot=%2Fcvsroot

Comment 5

[Conrad Carlen (not reading bugmail)]

The compiler options were not changed WRT long long support. They need to be but
weren't. That is worth a look. See bug 77205.

Are these instructions:
http://www.mozilla.org/projects/xpinstall/wizard/mac/debugging.html
the ones to use in order to test this?

Comment 6

[Stuart Moore]

It's a 6GB disk and I saw it with this friday's build 12/14.

Comment 7

[hirata masakazu]

I think this is a blocker.
1213, 1214, and 1217 builds all show this problem.
Strange no body has noticed it in smoketests.

Comment 8

[Conrad Carlen (not reading bugmail)]

Using the latest from sweetlou, it reports a negative amount of space available.
 However, using that build and running this installer test, I get the right result:

-------------------------------------------------------------------------------
http://jimbob/jars/a_fileop_filegetdiskspacea.xpi  --  12/18/2001 08:00:42
-------------------------------------------------------------------------------

     Acceptance: a_fileop_diskspaceavail
     -----------------------------------

     ** File.diskSpaceAvailable returns = 10203365376

     Install completed successfully
     Finished Installation  12/18/2001 08:00:42

That at least tells us where the problem is not. Can I build the installer in a
Carbon tree?

Comment 9

[Samir Gehani]

Conrad,
I'm not aware of any work to Carbonize the installer.  Doesn't mean it's not
been done though.

Comment 10

[Conrad Carlen (not reading bugmail)]

Attachment: patch to avoid overflow

Patch fixes it. The old code was probably getting overflow on the mult before
the divide. This keeps the value 64 bits wide until after the divide by 1024.

Comment 11

[Conrad Carlen (not reading bugmail)]

Looking for r=/sr (sgehani, dveditz)

Comment 12

[Daniel Veditz [:dveditz]]

Comment on attachment 62124 [details] [diff] [review]
patch to avoid overflow

sr=dveditz

Comment 13

[Samir Gehani]

Comment on attachment 62124 [details] [diff] [review]
patch to avoid overflow

r=sgehani

Comment 14

[Conrad Carlen (not reading bugmail)]

Fix checked in.

Comment 15

[TommyBee (No E-mail)]

*** Bug 116141 has been marked as a duplicate of this bug. ***

Comment 16

[TommyBee (No E-mail)]

Has the fix been checked in on the 0.9.7 branch as well?  I filed bug 116141
after experiencing the problem on the branch build.

Comment 17

[Conrad Carlen (not reading bugmail)]

No - but thanks for bringing this up. I just asked to get it into 0.9.7.

Comment 18

[Asa Dotzler [:asa]]

a=asa (on behalf of drivers) for checkin to 0.9.7

Comment 19

[Conrad Carlen (not reading bugmail)]

Checked into 0.9.7.

Comment 20

[K'Trina Medina]

Verified on build 2001-12-26-08-trunk, but I still need to verify it on a 0.9.7
branch build (the installer keeps defaulting to pause even if I continue to hit
resume using the last branch build from 12/21). 

Comment 21

[TommyBee (No E-mail)]

I had no problem installing 0.9.7 itself on OS 9.2.2

Comment 22

[K'Trina Medina]

Verified on build 2001-12-21-06-0.9.7