Closed
Bug 114581
Opened 24 years ago
Closed 24 years ago
table.deleteRow() exception not thrown
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
VERIFIED
FIXED
mozilla0.9.7
People
(Reporter: bernd_mozilla, Assigned: jst)
Details
(Keywords: testcase, Whiteboard: [HAVE FIX])
Attachments
(2 files)
|
722 bytes,
text/html
|
Details | |
|
1.45 KB,
patch
|
glazou
:
review+
jag+mozilla
:
superreview+
|
Details | Diff | Splinter Review |
http://www.w3.org/TR/2001/WD-DOM-Level-2-HTML-20011210/html.html#ID-64060425
Indicates that deleteRow() should throw an exeption if the row index to large or
to small.
|
Assignee | |
Comment 2•24 years ago
|
||
|
|
Assignee | |
Updated•24 years ago
|
Status: NEW → ASSIGNED
Whiteboard: [HAVE FIX]
Target Milestone: --- → mozilla0.9.7
Comment on attachment 61232 [details] [diff] [review]
Proposed fix.
r=glazman
Attachment #61232 -
Flags: review+
|
||
Comment 4•24 years ago
|
||
Comment on attachment 61232 [details] [diff] [review]
Proposed fix.
>- if (row) {
>- nsCOMPtr<nsIDOMNode> parent=nsnull;
>+ if (!row) {
>+ return NS_ERROR_DOM_INDEX_SIZE_ERR;
>+ }
>
>- row->GetParentNode(getter_AddRefs(parent));
>+ nsCOMPtr<nsIDOMNode> parent=nsnull;
I know you're just reindenting this, but there's no need for the nsnull
assignment here.
sr=jag if you change that.
Attachment #61232 -
Flags: superreview+
|
|
Assignee | |
Comment 5•24 years ago
|
||
Good catch, no more null assignment.
FIXED.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Component: DOM: HTML → DOM: Core & HTML
QA Contact: stummala → general
You need to log in
before you can comment on or make changes to this bug.
Description
•