114811 - Show ALL search icons in search menus

Status: VERIFIED FIXED

(SeaMonkey :: Search, defect)

Description

[Robert John Churchill]

Show ALL search icons in search menus.  If we have an associated image (gif, 
jpeg, etc) for a search file, use it... otherwise, on a Mac fallback to using a 
"moz-icon:" reference directly to the search file.

Comment 1

[Robert John Churchill]

Attachment: Use search icons

Comment 2

[Robert John Churchill]

Ben, please review.

Comment 3

[Ben Goodger (use ben at mozilla dot org for email)]

rather than creating a nsFileSpec with the path & making a nsFileURL for it, you
can do something like this:

  nsXPIDLCString fileURL;
  file->GetURL(getter_Copies(fileURL));
 
and append that to the iconURL string..
(for both the file & icon blocks)

do that, and (s)r=[e-mail].

Comment 4

[Robert John Churchill]

Ben:  Excellent, will do.

Comment 5

[Robert John Churchill]

Attachment: Incorporate ben's suggestions, and fix up indentation

Comment 6

[Steve Dagley]

Comment on attachment 61819 [details] [diff] [review]
Incorporate ben's suggestions, and fix up indentation

r=sdagley

Comment 7

[Robert John Churchill]

Fixed.

Comment 8

[sairuh (rarely reading bugmail)]

mass-verifying claudius' Fixed bugs which haven't changed since 2001.12.31.

if you think this particular bug is not fixed, please make sure of the following
before reopening:

a. retest with a *recent* trunk build.
b. query bugzilla to see if there's an existing, open bug (new, reopened,
assigned) that covers your issue.
c. if this does need to be reopened, make sure there are specific steps to
reproduce (unless already provided and up-to-date).

thanks!

[set your search string in mail to "AmbassadorKoshNaranek" to filter out these
messages.]