1151356 - "forget" button doesn't clear session cookie (with always use private browsing mode on)

Status: NEW

(Firefox :: Private Browsing, defect)

Description

[whocares]

User Agent: Mozilla/5.0 (X11; Linux i686; rv:10.0) Gecko/20100101 Firefox/10.0 Iceweasel/10.0
Build ID: 20150326190726

Steps to reproduce:

0. Set firefox:
[X] Always use private browsing mode
[ ]Accept cookies from sites
Exceptions:
my.test.server | Allow for session

1. Visit a werbsite which use cookie.
http://my.test.server/

2. Login normally and use it.
3. Click Firefox's forget button. Select 24 hours and clear it.
4. Firefox opened a new tab and said "done!".
5. Visit http://my.test.server/ again. You are still logged in.


Actual results:

With "Always use private browsing mode" turned on, Forget button doesn't clear ALL of cookies.


Expected results:

I want firefox to forget everything; even I'm using private browsing mode.

Comment 1

[Alice0775 White]

Error in Browser console:

A promise chain failed to handle a rejection. Did you forget to '.catch', or did you forget to 'return'?
See https://developer.mozilla.org/Mozilla/JavaScript_code_modules/Promise.jsm/Promise

Date: Mon Apr 06 2015 12:20:39 GMT+0900
Full Message: TypeError: this.Paths is null
Full Stack: Agent.wipe@resource:///modules/sessionstore/SessionWorker.js:236:7
worker.dispatch@resource:///modules/sessionstore/SessionWorker.js:21:24
anonymous/AbstractWorker.prototype.handleMessage@resource://gre/modules/workers/PromiseWorker.js:122:16
@resource:///modules/sessionstore/SessionWorker.js:30:41
 SessionWorker.js:236:0

Comment 2

[:Gijs (he/him)]

Tim, this looks like a session storage issue per comment #1 . Do you have time to take a look?

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

The "Paths is null" failure is probably the same as in bug 1183435. We'd need to find out whether removing cookies works and only sessionstore keeps them around, or whether even removing them doesn't work. Might be able to take a look this week, can't promise though.

Comment 4

[:Gijs (he/him)]

(In reply to Tim Taubert [:ttaubert] from comment #3)
> The "Paths is null" failure is probably the same as in bug 1183435. We'd
> need to find out whether removing cookies works and only sessionstore keeps
> them around, or whether even removing them doesn't work. Might be able to
> take a look this week, can't promise though.

I'm not sure I follow. Why would session store keep anything around in permanent private browsing mode?

Per bug 1201354 I would think that removing cookies is just broken, except I can't reproduce 1201354 myself...

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

(In reply to :Gijs Kruitbosch from comment #4)
> I'm not sure I follow. Why would session store keep anything around in
> permanent private browsing mode?

It collects cookies when a window is closed in case you want to restore it but they're never written to disk, and thus never restored after restarting.

> Per bug 1201354 I would think that removing cookies is just broken, except I
> can't reproduce 1201354 myself...

Yeah, agreed.

Comment 7

[:Gijs (he/him)]

I think this is just another incarnation of bug 463607. We should just disable the button in private windows and/or permanent private browsing mode.