115180 - repeating a Save As Complete does not replace main .html file

Status: VERIFIED WORKSFORME

(Core Graveyard :: File Handling, defect, P1)

Description

[sairuh (rarely reading bugmail)]

found using 2001.12.13 comm bits on winNT, linux and mac os x.

1. go to http://www.mozilla.org/
2. hit accel+S or File > Save Page As
3. take the default selection, "Save As Complete" [btw, that's the only choice
for Mac, due to bug 107521] and hit the Save button.
4. after download has finished, dismiss the progress dlg and note the timestamps
on the downloaded files.
5. repeat steps 2 and 3 --when prompted to replace the files, click Replace.

results: the download progress dlg is horked this time: the fields are blank and
only the Cancel button is enabled screenshot coming]. moreover, after clicking
Cancel, the retried download fails --since the timestamp is unchanged.

Comment 1

[sairuh (rarely reading bugmail)]

this doesn't appear to be a problem when saving as "only html" or "text".

Comment 2

[sairuh (rarely reading bugmail)]

Attachment: horked download progress dlg

Comment 3

[sairuh (rarely reading bugmail)]

...nor is this an issue with Save Link or Save Image from the context menu.

Comment 4

[Ben Goodger (use ben at mozilla dot org for email)]

Fixed. Patch w/analysis in bug 120174. 

Comment 5

[sairuh (rarely reading bugmail)]

tested this using 2002.01.23 comm bits, i find that i no longer get the horked
dialog, but am still unable to replace the content.

reopening, details below. however, let me know if this should be filed as
another bug.

* linux and win2k: repeating Save As complete will replace the contents in the
[page]_files directory, but *not* the primary [page].html file. eg, with
http://www.mozilla.org/ the files in www.mozilla.org_files/ are replaced, but
www.mozilla.org.html itself is *not*.

* mac os x: *none* of the files are replaced.

Comment 6

[sairuh (rarely reading bugmail)]

oops, correction: mac os x actually behaves the same as linux and win2k --main
file unchanged, but [page]_files files are replaced. at least it's consistent. :)

Comment 7

[Peter Trudelle]

nsbeta1+ per nav triage team

Comment 8

[Ben Goodger (use ben at mozilla dot org for email)]

-> 1.0

Comment 9

[Peter Trudelle]

New feature substantially not working, ->ADT1

Comment 10

[Ben Goodger (use ben at mozilla dot org for email)]

OK, I can no longer reproduce this on windows xp. Will try on Mac OS X. 

Comment 11

[Ben Goodger (use ben at mozilla dot org for email)]

This appears to have been fixed. I originally saw this on MacOS X, it no longer
manifests itself there on branch or trunk. I'm going to mark this WORKSFORME. 

Comment 12

[sairuh (rarely reading bugmail)]

yep, works fine now --vrfy'd using 2002.06.10.0x comm branch bits on linux,
win2k and mac 10.1.5.