Closed Bug 115999 Opened 23 years ago Closed 22 years ago

Better focus code in textbox.xml

Categories

(Core :: XUL, defect)

Product:
Core
Component:
XUL
Platform:
x86
Windows 95
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
RESOLVED WORKSFORME
Milestone:
Future

People

(Reporter: neil, Assigned: hyatt)

References

Details

(Keywords: polish)

Attachments

(1 file)

Proposed patch
1.64 KB, patch
Details | Diff | Splinter Review 
textbox.xml sets the focused attribute before focusing the internal input, which
might have the side effect of removing the focused attribute. Currently a flag
is used to hack around the problem but surely setting the attribute after
focusing the internal input would be more efficient?
Attached patch Proposed patch — — Splinter Review 

    
  
Keywords: patch, 
          
            polish, 
          
            review

    
    

    
  
CC Focus God bryner for code review.

    
  
Status: NEW → ASSIGNED
Target Milestone: --- → Future
Blocks: 123569

    
    

    
  
Are you sure that's the only reason textbox works this way?


    
    

    
  
Textboxes only set the focused attribute so that Mac Classic and Modern themes
can skin the focus effect.

    
    

    
  
hewitt should review this, he wrote the current code and would know if this
change will break anything.


    
    

    
  
This got fixed as part of the URLbar context menu selects all problem.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → WORKSFORME

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: