116071 - keyword field in pre-canned query not reflected in query screen when editing

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect, P1)

Description

[lchiang]

against: bugzilla 2.16 changes for bug 
http://bugzilla.mozilla.org/show_bug.cgi?id=98707 which have not been rolled 
into bugzilla.mozilla.org yet.

However, at Netscape, we've actually pulled the changes to query.cgi into our 
instance of bugzilla and have been using that version.  I've come across one 
"bug" about the query field.  

For example, I have a query where I set the keyword field to equal smoketest. 
Here is an example of the query (note: on my query, bugzilla.mozilla.org is
substituted by our database name)
http://bugzilla.mozilla.org/query.cgi?bug_severity=blocker&email1=&emailtype1=su
bstring&emailassigned_to1=1&email2=&emailtype2=substring&emailreporter2=1&bugidt
ype=include&bug_id=&changedin=&votes=&chfield=%5BBug+creation%5D&chfieldfrom=12%
2F3%2F2001&chfieldto=12%2F9%2F2001&chfieldvalue=&product=Browser&product=Browser
+Localizations&product=CCK&product=MailNews&product=NSPR&product=NSS&product=PSM
&short_desc=&short_desc_type=substring&long_desc=&long_desc_type=substring&bug_f
ile_loc=&bug_file_loc_type=substring&status_whiteboard=&status_whiteboard_type=s
ubstring&keywords=smoketest&keywords_type=anywords&field0-0-0=noop&type0-0-0=noo
p&value0-0-0=&cmdtype=doit&namedcmd=bugs+for+triage&newqueryname=&order=Bug+Numb
er

Using the newer query.cgi screen, I run this query.
Then, I choose to "edit this query"
The problem is that the keyword field is in the advance fields and no longer
just a plain text field and when I edit the query, the keyword field doesn't get
populated automatically.

Note:  Luckily, I knew the the results I got back was larger than normal and
looked into it further.  This problem may cause some false hits/totals for other
people who run pre-canned queries after doing a minor modification to the query.

Comment 1

[Jason Kersey]

I'd really like to see a dedicated keyword field again in the query interface,
as it's a commonly used feature.  I ran into this just today.  Over to mpt to
see what he thinks, as he designed the new query.

Comment 2

[Matthew Tuck [:CodeMachine]]

Not sure what we can do about this.  Perhaps an appropriate solution is to
remove keyword support from buglist.cgi.  Then we could convert existing stored
queries, and implement bug #87966 to handle bookmarks.

I'm hesitant to do this however, because it would prohibit allowing a keyword
field to be added to the template.

Perhaps the solution is that the template needs to recognise the keyword
parameter, and render it as an advanced query condition.

Or we could just add the field back for 2.16.

Comment 3

[lchiang]

If possible, I would love for the (keyword) field to be added back into the
query screen.   I'm getting many requests on what happened to the keyword field
and how to query for keywords (in Bugscape which has already taken the latest
code changes) as it's not very obvious in the advanced section of the query screen.

Comment 4

[Matthew Tuck [:CodeMachine]]

According to bug #118774, it's meant to be there.

Comment 5

[Dave Miller [:justdave]]

Ping...

mpt, you own this.  Any thoughts?  We're in countdown mode for 2.16

Comment 6

[Andreas Franke (gone)]

I agree with people here that the "keywords" field should re-added to the query
page.

Comment 7

[Dave Miller [:justdave]]

see bug 118774, the query field has been added back to the query page.

Did that help this any or is this situation still broken?

Comment 8

[lchiang]

If the keywords field has been added back to the query page, then the bug I
originally reported (with pre-canned queries) should be fixed.  But, I cannot
verify that unless I have a new installation to work with where I had a
precanned query against an old bugzilla version and run the same query against a
new installation (to look for false matches).

Comment 9

[Matthew Tuck [:CodeMachine]]

This is fixed, reloading works on landfill for keywords.  There doesn't seem to
be any other fields missing now.  Also the field names are the same so there
will be no problems loading old bookmarks or stored queries.

Comment 10

[Matthew T (active 1999-2002)]

This was never my bug. My design for the new search page, attachment 50517 [details], 
clearly includes a Keywords field.