1161750 - [Settings][Date&Time] Toggling Automatic and Manual setting pushes/indents 'Region' and 'City' text up

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Oliver Nelson [:oliverthor]]

Attachment: logcat_20150505_1352.txt

Description:
When the user toggles the behavior of automatic or manually setting the timezone on the phone, they will observe that the text within region ['America', 'Europe', 'Asia', 'Africa' ... etc] will shift upwards in it's text window.
** 'City' text is not visible on 2.2 and 3.0 devices, as tapping the toggle 'resets' the view of the page to the toggle-button and pushes 'City' off-view

Repro Steps:
1) Update a Flame to 20150505010204
2) Open the Settings app
3) Navigate to Date & Time
4) Toggle between manual and automatic setting while observing 'Region' text

Actual:
'Region' and 'City' text shifts it's vertical position when manual setting is toggled

Expected:
No text shifts position when manual setting is toggled


Environmental Variables:
----------------------------------------

Device: Flame 3.0
Build ID: 20150505010204
Gaia: 70077825aab2c7a79611befb40a5fe7e610d5443
Gecko: 102d0e9aa9e1
Gonk: a9f3f8fb8b0844724de32426b7bcc4e6dc4fa2ed
Version: 40.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

Device: Flame 2.2
BuildID: 20150505002501
Gaia: 772a9491909abd02dc67278dd453746e2dd358a8
Gecko: 2df83538ae20
Gonk: ab265fb203390c70b8f2a054f38cf4b2f2dad70a
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Device: Flame 2.1
BuildID: 20150505001204
Gaia: b4a03b7ee61de5a479b3cf0916f47e91a43b0f50
Gecko: 4493015380ab
Gonk: ab265fb203390c70b8f2a054f38cf4b2f2dad70a
Version: 34.0 (2.1) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
********************************************

Date&Time has a different interface that is not affected by this issue in 2.0 for flame devices.

Device: Flame 2.0
BuildID: 20150505000201
Gaia: 84898cadf28b1a1fcd03b726cff658de470282f0
Gecko: e67ed29e8ad0
Gonk: ab265fb203390c70b8f2a054f38cf4b2f2dad70a
Version: 32.0 (2.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0
----------------------------------------

Repro frequency: 5/5
See attached: 
video- https://youtu.be/OUXsolQxsEg
logcat

Comment 1

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Seems minor, but would be nice to have fixed. Marking polish for now. NI component owner to take a look.

Comment 2

[Gerry Chang [:gchang]]

This is more like a polish issue. Add developer in CC.

Comment 3

[Yu-wen Pwu]

I would like to fix the bug, but I need more info. (e.g. Where is the related files located ?)

In the video, I see the string "America" changes its vertical position when toggling, which is not expected to happen. Are there any other problem that should be fixed?

Thanks!

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks for contributing!

The only issue here is that the positioning of region and city texts. We usually use WebIDE[1] to debug UI issues. When you connect your device to WebIDE, you should be able to locate the element and find the related css files. Feel free to let me know should any problems.

[1]: https://developer.mozilla.org/zh-TW/docs/Tools/WebIDE

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] yuwen41200:master > mozilla-b2g:master

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8606680 [details] [review]
[gaia] yuwen41200:master > mozilla-b2g:master

Thanks for the cleanup! Please add "r=arthur" in the end of the commit message in github. And then add "checkin-needed" keyword on this bug. Autolander will merge the PR for you.

Comment 7

[GitHub Autolander Bot]

http://docs.taskcluster.net/tools/task-graph-inspector/#OVqQqYFbR3qvFA2mvu0FiQ

The pull request failed to pass integration tests. It could not be landed, please try again.

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

It seems there are problems with the tests but I don't think it's due to your patch. Please re-add the keyword to trigger the landing again.

And I forgot to mention, the title of the PR should be in the format "Bug id - one line description of your patch r=reviewer" but not the title of the bug. Please also update the title before merging, thanks!

Comment 9

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/d88c2f98ebdc75f8eb4d54de0ef267f32414618f

Comment 10

[Shally Li（leave from Mozilla）]

Per Comment 9,this bug has been landed and fixed on master.


This bug has been verified as pass on latest Nightly build of Flame v3.0 and Nexus 5 v3.0.

See attachment: verified_v3.0.mp4
Reproduce rate: 0/8

STR:
1.Power on deivce without SIM card (or with SIM card).
2.Connect a wifi.
3.Go to Settings->Date&Time.
4.Change the Region(Select all regions), then enable/disable 'Set Automatically'.
**No text shifts position.--OK

Note:
When you insert SIM card,the design of "Time Zone" have changed on v3.0:
It shows "UT+08:00" instead of region&city text when enabling 'Set Automatically',and it shows Region&City when disable 'Set Automatically'.The region&city text will not shift position.

-------------------------------------------------------------------------------
Device: Flame v3.0 build (Pass)
Build ID               20150521160241
Gaia Revision          1126d8bee559f7cde675df2fcc6c196da9cfeba1
Gaia Date              2015-05-21 21:23:56
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/3e737d30f842
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150521.193021
Firmware Date          Thu May 21 19:30:31 EDT 2015
Bootloader             L1TC000118D0

Device: Nexus 5 v3.0 build (Pass)
Build ID               20150521160241
Gaia Revision          1126d8bee559f7cde675df2fcc6c196da9cfeba1
Gaia Date              2015-05-21 21:23:56
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/3e737d30f842
Gecko Version          41.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150521.193039
Firmware Date          Thu May 21 19:30:54 EDT 2015
Bootloader             HHZ12f

Comment 11

[Shally Li（leave from Mozilla）]

Attachment: verified_v3.0.mp4